[improve][broker] Make cluster metadata teardown command support metadata config path #23520
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Demogorgon314
requested review from
lhotari,
tuteng,
Technoboy-,
BewareMyPower,
poorbarcode,
coderzc and
mattisonchao
poorbarcode
approved these changes
Oct 28, 2024
nodece
requested changes
Oct 28, 2024
pulsar-broker/src/main/java/org/apache/pulsar/PulsarClusterMetadataTeardown.java
Outdated
Show resolved
Hide resolved
pulsar-broker/src/main/java/org/apache/pulsar/PulsarClusterMetadataTeardown.java
Outdated
Show resolved
Hide resolved
nodece
reviewed
Oct 28, 2024
pulsar-broker/src/main/java/org/apache/pulsar/PulsarClusterMetadataTeardown.java
Outdated
Show resolved
Hide resolved
nodece
approved these changes
Oct 28, 2024
nikhil-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Nov 20, 2024
…data config path (apache#23520) (cherry picked from commit 69ca0cb) (cherry picked from commit 271fee2)
srinath-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Nov 21, 2024
…data config path (apache#23520) (cherry picked from commit 69ca0cb) (cherry picked from commit 271fee2)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The pulsar configuration supported
metadataStoreConfigPathandconfigurationStoreConfigPath, but the cluster metadata teardown command does not have a place to set the config path.Modifications
Make cluster metadata init command support metadata config path
Documentation
docdoc-requireddoc-not-neededdoc-complete