-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[improve][broker] Support cleanup replication cluster
and allowed cluster
when cluster metadata teardown
#23561
Conversation
…en cluster metadata teardown
…ter metadata teardown
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #23561 +/- ##
============================================
+ Coverage 73.57% 74.33% +0.75%
- Complexity 32624 34427 +1803
============================================
Files 1877 1943 +66
Lines 139502 147083 +7581
Branches 15299 16214 +915
============================================
+ Hits 102638 109331 +6693
- Misses 28908 29315 +407
- Partials 7956 8437 +481
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Motivation
When executing the
delete-cluster-metadata
command, it should remove the current cluster from thereplication cluster
andallowed cluster
, otherwise the cluster will still replicate the data to a deleted cluster.Modifications
Support cleanup
replication cluster
andallowed cluster
when cluster metadata teardownDocumentation
doc
doc-required
doc-not-needed
doc-complete