Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[improve][broker] Support cleanup replication cluster and allowed cluster when cluster metadata teardown #23561

Conversation

Demogorgon314
Copy link
Member

Motivation

When executing the delete-cluster-metadata command, it should remove the current cluster from the replication cluster and allowed cluster, otherwise the cluster will still replicate the data to a deleted cluster.

Modifications

Support cleanup replication cluster and allowed cluster when cluster metadata teardown

Documentation

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

@Demogorgon314 Demogorgon314 added type/enhancement The enhancements for the existing features or docs. e.g. reduce memory usage of the delayed messages area/broker release/3.1.4 release/3.2.5 release/3.3.3 release/3.0.8 release/4.0.1 labels Nov 5, 2024
@Demogorgon314 Demogorgon314 self-assigned this Nov 5, 2024
@github-actions github-actions bot added the doc-not-needed Your PR changes do not impact docs label Nov 5, 2024
Copy link
Member

@lhotari lhotari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov-commenter
Copy link

codecov-commenter commented Nov 6, 2024

Codecov Report

Attention: Patch coverage is 92.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 74.33%. Comparing base (bbc6224) to head (9519f69).
Report is 717 commits behind head on master.

Files with missing lines Patch % Lines
...g/apache/pulsar/PulsarClusterMetadataTeardown.java 92.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##             master   #23561      +/-   ##
============================================
+ Coverage     73.57%   74.33%   +0.75%     
- Complexity    32624    34427    +1803     
============================================
  Files          1877     1943      +66     
  Lines        139502   147083    +7581     
  Branches      15299    16214     +915     
============================================
+ Hits         102638   109331    +6693     
- Misses        28908    29315     +407     
- Partials       7956     8437     +481     
Flag Coverage Δ
inttests 27.57% <92.00%> (+2.99%) ⬆️
systests 24.36% <0.00%> (+0.04%) ⬆️
unittests 73.72% <84.00%> (+0.87%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...g/apache/pulsar/PulsarClusterMetadataTeardown.java 77.51% <92.00%> (+1.76%) ⬆️

... and 660 files with indirect coverage changes

@Demogorgon314 Demogorgon314 merged commit 0969869 into apache:master Nov 12, 2024
52 checks passed
@Demogorgon314 Demogorgon314 deleted the Demogorgon314/Support-cleanup-replication-cluster-for-all-tenants-and-namespaces branch November 12, 2024 08:59
lhotari pushed a commit that referenced this pull request Nov 13, 2024
…cluster` when cluster metadata teardown (#23561)

(cherry picked from commit 0969869)
lhotari pushed a commit that referenced this pull request Nov 13, 2024
…cluster` when cluster metadata teardown (#23561)

(cherry picked from commit 0969869)
lhotari pushed a commit that referenced this pull request Nov 13, 2024
…cluster` when cluster metadata teardown (#23561)

(cherry picked from commit 0969869)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/broker cherry-picked/branch-3.0 cherry-picked/branch-3.3 cherry-picked/branch-4.0 doc-not-needed Your PR changes do not impact docs release/3.0.8 release/3.3.3 release/4.0.1 type/enhancement The enhancements for the existing features or docs. e.g. reduce memory usage of the delayed messages
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants