[fix][client] fix the beforeConsume() method earlier hit with message listener #23578
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codelipenghui
added
ready-to-test
type/bug
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #23578 +/- ##
============================================
+ Coverage 73.57% 74.36% +0.78%
- Complexity 32624 34951 +2327
============================================
Files 1877 1943 +66
Lines 139502 147072 +7570
Branches 15299 16215 +916
============================================
+ Hits 102638 109364 +6726
- Misses 28908 29281 +373
- Partials 7956 8427 +471
Flags with carried forward coverage won't be shown. Click here to find out more.
|
poorbarcode
approved these changes
Nov 8, 2024
Technoboy-
approved these changes
Nov 8, 2024
coderzc
approved these changes
Nov 8, 2024
shibd
approved these changes
Nov 8, 2024
nikhil-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Nov 20, 2024
… listener (apache#23578) (cherry picked from commit 137df29) (cherry picked from commit c303cc6)
srinath-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Nov 21, 2024
… listener (apache#23578) (cherry picked from commit 137df29) (cherry picked from commit c303cc6)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
This is a fix follow up #23141 which does not cover the earlier hit for beforeConsume() method with message listener. Instead of calling the interceptor before put the message listener task to the message listener thread pool, we should move it to the inside of the message listener task. So that users will not get an earlier hit of the beforeConsume() method in the interceptor.
The expected behavior should be
Without this fix, the actual behavior was
Does this pull request potentially affect one of the following parts:
If the box was checked, please highlight the changes
Documentation
docdoc-requireddoc-not-neededdoc-completeMatching PR in forked repository
PR in forked repository: