-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[improve][broker] PIP-392: Add configuration to enable consistent hashing to select active consumer for partitioned topic #23584
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
doc-required
Your PR changes impact docs and you will update later.
label
Nov 11, 2024
4 tasks
…hing to select active consumer for partitioned topic
shibd
added
type/enhancement
The enhancements for the existing features or docs. e.g. reduce memory usage of the delayed messages
ready-to-test
labels
Nov 20, 2024
shibd
requested review from
lhotari,
Technoboy-,
RobertIndie and
poorbarcode
November 20, 2024 13:01
/pulsarbot rerun-failure-checks |
RobertIndie
approved these changes
Nov 20, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #23584 +/- ##
============================================
+ Coverage 73.57% 74.35% +0.78%
- Complexity 32624 34335 +1711
============================================
Files 1877 1943 +66
Lines 139502 147074 +7572
Branches 15299 16215 +916
============================================
+ Hits 102638 109361 +6723
- Misses 28908 29275 +367
- Partials 7956 8438 +482
Flags with carried forward coverage won't be shown. Click here to find out more.
|
poorbarcode
approved these changes
Nov 21, 2024
hi, Accouding the vote thread mentions. I cherry-picked this to branch-4.0, branch-3.3, and branch-3.0 |
nikhil-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Nov 26, 2024
…hing to select active consumer for partitioned topic (apache#23584) (cherry picked from commit 49aa308) (cherry picked from commit ea8b659)
srinath-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Nov 26, 2024
…hing to select active consumer for partitioned topic (apache#23584) (cherry picked from commit 49aa308) (cherry picked from commit ea8b659)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
cherry-picked/branch-3.0
cherry-picked/branch-3.3
cherry-picked/branch-4.0
doc-required
Your PR changes impact docs and you will update later.
ready-to-test
release/3.0.8
release/3.3.3
release/4.0.1
type/enhancement
The enhancements for the existing features or docs. e.g. reduce memory usage of the delayed messages
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
#23583
Modifications
Verifying this change
testPartitionedTopicDistribution
to cover itDocumentation
doc
doc-required
doc-not-needed
doc-complete