Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[improve][broker] PIP-392: Add configuration to enable consistent hashing to select active consumer for partitioned topic #23584

Merged
merged 1 commit into from
Nov 21, 2024

Conversation

shibd
Copy link
Member

@shibd shibd commented Nov 11, 2024

Motivation

#23583

Modifications

  • Only use mod when topic is partitionedTopic and activeConsumerFailoverConsistentHashing=false.

Verifying this change

  • Add testPartitionedTopicDistribution to cover it

Documentation

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

@shibd shibd self-assigned this Nov 11, 2024
@github-actions github-actions bot added the doc-required Your PR changes impact docs and you will update later. label Nov 11, 2024
…hing to select active consumer for partitioned topic
@shibd shibd added type/enhancement The enhancements for the existing features or docs. e.g. reduce memory usage of the delayed messages ready-to-test labels Nov 20, 2024
@shibd shibd marked this pull request as ready for review November 20, 2024 13:01
@shibd
Copy link
Member Author

shibd commented Nov 20, 2024

/pulsarbot rerun-failure-checks

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.35%. Comparing base (bbc6224) to head (f9d2d7b).
Report is 737 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##             master   #23584      +/-   ##
============================================
+ Coverage     73.57%   74.35%   +0.78%     
- Complexity    32624    34335    +1711     
============================================
  Files          1877     1943      +66     
  Lines        139502   147074    +7572     
  Branches      15299    16215     +916     
============================================
+ Hits         102638   109361    +6723     
- Misses        28908    29275     +367     
- Partials       7956     8438     +482     
Flag Coverage Δ
inttests 27.54% <66.66%> (+2.96%) ⬆️
systests 24.37% <66.66%> (+0.05%) ⬆️
unittests 73.73% <100.00%> (+0.88%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...org/apache/pulsar/broker/ServiceConfiguration.java 98.98% <100.00%> (-0.42%) ⬇️
...ervice/AbstractDispatcherSingleActiveConsumer.java 90.40% <100.00%> (-0.16%) ⬇️

... and 658 files with indirect coverage changes

---- 🚨 Try these New Features:

@poorbarcode poorbarcode merged commit 49aa308 into apache:master Nov 21, 2024
58 checks passed
shibd added a commit that referenced this pull request Nov 21, 2024
…hing to select active consumer for partitioned topic (#23584)

(cherry picked from commit 49aa308)
shibd added a commit that referenced this pull request Nov 21, 2024
…hing to select active consumer for partitioned topic (#23584)

(cherry picked from commit 49aa308)
shibd added a commit that referenced this pull request Nov 21, 2024
…hing to select active consumer for partitioned topic (#23584)

(cherry picked from commit 49aa308)
@shibd
Copy link
Member Author

shibd commented Nov 21, 2024

hi, Accouding the vote thread mentions. I cherry-picked this to branch-4.0, branch-3.3, and branch-3.0

nikhil-ctds pushed a commit to datastax/pulsar that referenced this pull request Nov 26, 2024
…hing to select active consumer for partitioned topic (apache#23584)

(cherry picked from commit 49aa308)
(cherry picked from commit ea8b659)
srinath-ctds pushed a commit to datastax/pulsar that referenced this pull request Nov 26, 2024
…hing to select active consumer for partitioned topic (apache#23584)

(cherry picked from commit 49aa308)
(cherry picked from commit ea8b659)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-picked/branch-3.0 cherry-picked/branch-3.3 cherry-picked/branch-4.0 doc-required Your PR changes impact docs and you will update later. ready-to-test release/3.0.8 release/3.3.3 release/4.0.1 type/enhancement The enhancements for the existing features or docs. e.g. reduce memory usage of the delayed messages
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants