[fix][broker] Fix failed TokenAuthenticatedProducerConsumerTest

[BewareMyPower]

Motivation

TokenAuthenticatedProducerConsumerTest cannot pass the test. The root cause is that when a namespace does not exist and the client carries a token without correct permission, the client would fail with AuthorizationException but not TopicDoesNotExistException.

It's because PulsarAuthorizationProvider#validateTenantAdminAccess will fail exceptionally by NotFoundException here:

pulsar/pulsar-broker-common/src/main/java/org/apache/pulsar/broker/authorization/PulsarAuthorizationProvider.java

Line 718 in 0b0eef9

if (cause instanceof NotFoundException) {

However, when the namespace does not exist, this exception won't be thrown. If testTopicNotFound was running after testTokenProducerAndConsumer, the "my-property" tenant would be created so it would fail.

However, the CI somehow passed and I see 1 test was skipped.

Warning:  Tests run: 6, Failures: 0, Errors: 0, Skipped: 1, Time elapsed: 22.034 s - in org.apache.pulsar.client.api.TokenAuthenticatedProducerConsumerTest

Modifications

Change the test from testTopicNotFound to testTenantNotExist and use a tenant that does not exist.

Regarding the case when the namespace does not exist, we might need another PR for it.

Documentation

• doc
• doc-required
• doc-not-needed
• doc-complete

Matching PR in forked repository

PR in forked repository:

[lhotari]

LGTM

[codecov-commenter]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.33%. Comparing base (bbc6224) to head (1928598).
Report is 734 commits behind head on master.

Additional details and impacted files

@@             Coverage Diff              @@
##             master   #23602      +/-   ##
============================================
+ Coverage     73.57%   74.33%   +0.76%     
- Complexity    32624    34437    +1813     
============================================
  Files          1877     1944      +67     
  Lines        139502   147127    +7625     
  Branches      15299    16225     +926     
============================================
+ Hits         102638   109372    +6734     
- Misses        28908    29313     +405     
- Partials       7956     8442     +486     

Flag	Coverage Δ
inttests	27.71% <ø> (+3.13%)	⬆️
systests	24.36% <ø> (+0.04%)	⬆️
unittests	73.71% <ø> (+0.86%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 653 files with indirect coverage changes

---- 🚨 Try these New Features:

• Flaky Tests Detection - Detect and resolve failed and flaky tests
• JS Bundle Analysis - Avoid shipping oversized bundles