-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[improve] Improve logic for enabling Netty leak detection #23613
Merged
lhotari
merged 3 commits into
apache:master
from
lhotari:lh-improve-enabling-netty-leak-detector
Nov 21, 2024
Merged
[improve] Improve logic for enabling Netty leak detection #23613
lhotari
merged 3 commits into
apache:master
from
lhotari:lh-improve-enabling-netty-leak-detector
Nov 21, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lhotari
requested review from
merlimat,
hangc0276,
eolivelli,
codelipenghui,
nodece,
BewareMyPower,
nicoloboschi,
poorbarcode and
heesung-sn
November 20, 2024 14:28
lhotari
added
ready-to-test
and removed
doc-not-needed
Your PR changes do not impact docs
labels
Nov 20, 2024
lhotari
changed the title
[improve][common] Improve logic for enabling Netty leak detection
[improve] Improve logic for enabling Netty leak detection
Nov 20, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #23613 +/- ##
============================================
+ Coverage 73.57% 74.37% +0.80%
- Complexity 32624 34987 +2363
============================================
Files 1877 1944 +67
Lines 139502 147134 +7632
Branches 15299 16224 +925
============================================
+ Hits 102638 109438 +6800
- Misses 28908 29253 +345
- Partials 7956 8443 +487
Flags with carried forward coverage won't be shown. Click here to find out more.
|
heesung-sn
approved these changes
Nov 20, 2024
dao-jun
approved these changes
Nov 20, 2024
nodece
approved these changes
Nov 21, 2024
lhotari
added a commit
that referenced
this pull request
Nov 21, 2024
(cherry picked from commit 949750f)
lhotari
added a commit
that referenced
this pull request
Nov 21, 2024
(cherry picked from commit 949750f)
lhotari
added a commit
that referenced
this pull request
Nov 21, 2024
(cherry picked from commit 949750f)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
cherry-picked/branch-3.0
cherry-picked/branch-3.3
cherry-picked/branch-4.0
doc-not-needed
Your PR changes do not impact docs
ready-to-test
release/3.0.8
release/3.3.3
release/4.0.1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Currently it's tricky and confusing to enable the Netty leak detector for Pulsar broker and Pulsar clients.
The current logic expects that
pulsar.allocator.leak_detection
is set. The standard property for Netty isio.netty.leakDetection.level
(legacy propertyio.netty.leakDetectionLevel
).One additional challenge in setting the
pulsar.allocator.leak_detection
property is that the value is case sensitive. It must be set toDisabled
,Simple
,Advanced
orParanoid
instead ofdisabled
,simple
,advanced
orparanoid
.Modifications
io.netty.leakDetectionLevel
(legacy Netty property)io.netty.leakDetection.level
(standard Netty property)pulsar.allocator.leak_detection
(Pulsar's property)Documentation
doc
doc-required
doc-not-needed
doc-complete