Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix][broker] support missing tenant level fine-granted permissions #23660

Merged
merged 8 commits into from
Nov 29, 2024

Conversation

mattisonchao
Copy link
Member

Motivation

Support missing tenant-level fine-granted permissions.

Modifications

  • Add missing tenant-level operations
  • Keep compatibility for existing superuser validation.

Verifying this change

  • Make sure that the change passes the CI checks.

Documentation

  • doc-not-needed

@mattisonchao mattisonchao added this to the 4.1.0 milestone Nov 29, 2024
@codecov-commenter
Copy link

codecov-commenter commented Nov 29, 2024

Codecov Report

Attention: Patch coverage is 57.57576% with 14 lines in your changes missing coverage. Please review.

Project coverage is 74.35%. Comparing base (bbc6224) to head (2a09e03).
Report is 771 commits behind head on master.

Files with missing lines Patch % Lines
...g/apache/pulsar/broker/admin/impl/TenantsBase.java 50.00% 12 Missing and 2 partials ⚠️
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##             master   #23660      +/-   ##
============================================
+ Coverage     73.57%   74.35%   +0.77%     
- Complexity    32624    35038    +2414     
============================================
  Files          1877     1944      +67     
  Lines        139502   147327    +7825     
  Branches      15299    16257     +958     
============================================
+ Hits         102638   109542    +6904     
- Misses        28908    29337     +429     
- Partials       7956     8448     +492     
Flag Coverage Δ
inttests 27.38% <45.45%> (+2.79%) ⬆️
systests 24.38% <39.39%> (+0.05%) ⬆️
unittests 73.74% <57.57%> (+0.89%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...e/pulsar/common/policies/data/TenantOperation.java 100.00% <100.00%> (ø)
...g/apache/pulsar/broker/admin/impl/TenantsBase.java 89.08% <50.00%> (-7.38%) ⬇️

... and 665 files with indirect coverage changes

@mattisonchao mattisonchao merged commit 280997e into apache:master Nov 29, 2024
52 checks passed
lhotari pushed a commit that referenced this pull request Nov 29, 2024
mattisonchao added a commit that referenced this pull request Dec 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants