close client connectionon tooManyRequest and internal-server error #274
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rdhabalia
added
area/client
type/enhancement
merlimat
reviewed
Mar 5, 2017
| @@ -61,6 +64,13 @@ | |||
|
|
|||
| private final CompletableFuture<Void> connectionFuture = new CompletableFuture<Void>(); | |||
| private final Semaphore pendingLookupRequestSemaphore; | |||
| private final Timer timer; | |||
There was a problem hiding this comment.
We should already have a ScheduledExecutor instance around that we can use.
There was a problem hiding this comment.
actually we don't have ScheduledExecutor instance around. should we create one?
There was a problem hiding this comment.
that's true, then we could use the eventLoop associated with the netty channel to schedule the task.
(If we use a timer per connection, it will create a different thread for each of them)
There was a problem hiding this comment.
yes, that's right. fixed it.
rdhabalia
force-pushed
the
close_client
branch
3 times, most recently
from
4a35d90
to
90ce6e3
Compare
merlimat
reviewed
Mar 8, 2017
| @@ -61,6 +65,13 @@ | |||
|
|
|||
| private final CompletableFuture<Void> connectionFuture = new CompletableFuture<Void>(); | |||
| private final Semaphore pendingLookupRequestSemaphore; | |||
| private final EventLoopGroup eventLoopGroup; | |||
| private Timeout timeoutTask; | |||
sijie
pushed a commit
to sijie/pulsar
that referenced
this pull request
Mar 4, 2018
hangc0276
pushed a commit
to hangc0276/pulsar
that referenced
this pull request
May 26, 2021
…pache#274) Fixes apache#273 When KoP handles metadata requests, it only checks the config allowAutoTopicCreation but not the same field in the metadata request. Then it causes that AdminClient#describeTopics returns a success result even if the topics don't exist and topics will be created automatically. So this PR adds the check for metadata request's allowAutoTopicCreation field and the test for AdminClient#describeTopics.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Client creates a dedicated binary-proto lookup connection with one broker and there could be a possibility
In that case, client should close the existing connection and try to recreate which may end up with new connection with other broker and do successful lookup.
Modifications
check serverError and take appropriate action
Result
Client can recreate connection with different broker if it is not able to getting successful response from one particular broker.
NOTE
I have created this PR on top of #181 changes as it requires ServerSide throttling.
So, this PR depends on #181 and we need to merge #181 first.