Async call for broker stats #305
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 12 commits
March 2, 2017 16:28
|
@merlimat @saandrews @msb-at-yahoo - Can you please give me a +1 on this - need to get it into production |
merlimat
approved these changes
Apr 6, 2017
There was a problem hiding this comment.
LGTM, but try to get more @msb-at-yahoo or @saandrews to check it as well
|
can you rebase this to one commit? |
|
@msb-at-yahoo Merging the PR will anyway force a squash. I've configured github to only leave that option ;) |
msb-at-yahoo
reviewed
Apr 6, 2017
| private: | ||
| boost::shared_ptr<BrokerConsumerStatsImplBase> impl_; | ||
| public: | ||
| BrokerConsumerStats(boost::shared_ptr<BrokerConsumerStatsImplBase> impl); |
There was a problem hiding this comment.
this constructor should be explicit
|
|
||
| friend std::ostream& operator<<(std::ostream &os, const BrokerConsumerStats &obj); | ||
| }; | ||
| typedef boost::shared_ptr<BrokerConsumerStats> BrokerConsumerStatsPtr; |
There was a problem hiding this comment.
why do you need a shared_ptr here if BrokerConsumerStats is already basically a shared_ptr and is allowed to be invalid?
| } | ||
|
|
||
| double BrokerConsumerStats::getMsgRateOut() const { | ||
| if (impl_) { |
There was a problem hiding this comment.
it would be more idiomatic to just document that no getXXX is allowed on an invalid BrokerConsumerStats object and get rid of the check. that avoids hiding bugs.
jai1
force-pushed
the
AsyncCallForBrokerStats
branch
from
f4933c8 to
c5a2404
Compare
saandrews
approved these changes
Apr 7, 2017
hrsakai
pushed a commit
to hrsakai/pulsar
that referenced
this pull request
Dec 10, 2020
…ageID for ReaderOptions (apache#305) ### Motivation User of the client's client's [CreateReader](https://github.com/apache/pulsar-client-go/blob/master/pulsar/client.go#L109) API can use a custom type satisfying the [MessageID](https://github.com/apache/pulsar-client-go/blob/master/pulsar/message.go#L108) interface, when using it as a value for `StartMessageID` in [ReaderOptions](https://github.com/apache/pulsar-client-go/blob/master/pulsar/reader.go#L48) argument for the mentioned API. The current reader creation does an untested type assertion here, when preparing the `consumerOptions` needed for creating a `partitionConsumer`. https://github.com/apache/pulsar-client-go/blob/master/pulsar/reader_impl.go#L64 This assertion of `MessageID` as `*messageID` will fail unless an instance of `MessageID` is created from one of these exported APIs because `messageID` is unexported https://github.com/apache/pulsar-client-go/blob/master/pulsar/message.go#L114-#L126 Note: `newMessageID` returns `*messageID` which satisfies `MessageID` interface as well. ### Modifications Test the type assertion of `MessageID` as `*messageID`, if it fails, re-create a new `MessageID` using this https://github.com/apache/pulsar-client-go/blob/975eb3781644ebe588fc142e53eadf39fe50341a/pulsar/impl_message.go#L97 This will ensure that the custom type can be re-created as a `*messageID` which can be used by `partitionConsumerOpts`
hangc0276
pushed a commit
to hangc0276/pulsar
that referenced
this pull request
May 26, 2021
Fixes apache#299 PulsarEntryFormatter doesn't handle null value correctly now. If a message with null value was sent by a producer, the consumer will receive a message with an empty string. This PR fixes the bug and adds to tests to verify KoP could handle the null value no matter what the entry format is.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Added async call for getBrokerConsumerStats and refactored the code to keep partitions abstract.
Modifications
Almost all Consumer* files modified to support BrokerConsumerStats
Result