Feature / Interceptor for negative ack redelivery #3962
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sijie
added
area/client
type/feature
merlimat
reviewed
Apr 2, 2019
pulsar-client/src/main/java/org/apache/pulsar/client/impl/ConsumerInterceptors.java
Outdated
Show resolved
Hide resolved
lovelle
force-pushed
the
feature/add_negative_ack_redelivery_interceptor
branch
from
c184be5 to
7a8a532
Compare
|
run integration tests |
merlimat
reviewed
Apr 19, 2019
pulsar-client/src/main/java/org/apache/pulsar/client/impl/ConsumerInterceptors.java
Outdated
Show resolved
Hide resolved
*Motivation* In some scenarios is it helpful to be able to set interceptor for redeliveries being happening due to negative acknowledge. *Modifications* - Add onNegativeAcksSend() method in ConsumerInterceptor interface. - Add handler for onNegativeAcksSend() interceptor in ConsumerBase. - Favor forEach on ConsumerInterceptor instead of classic for loop by index. - Optimization for each by index to avoid compute size() every iteration. - Add call method to onNegativeAckRedelivery() from NegativeAcksTracker.
lovelle
force-pushed
the
feature/add_negative_ack_redelivery_interceptor
branch
from
7a8a532 to
e140df9
Compare
|
run java8 tests |
1 similar comment
|
run java8 tests |
5 tasks
RobertIndie
added a commit
to apache/pulsar-client-cpp
that referenced
this pull request
Mar 21, 2023
### Motivation This PR is the C++ implementation of apache/pulsar#3962 ### Modifications * Add `onNegativeAcksSend` to the consumer interceptor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
In some scenarios is it helpful to be able to set interceptor for redeliveries
being happening due to negative acknowledge.
Modifications
Verifying this change