PIP-34 Add flag to enable or disable Key_Shared subscription. #4120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Apr 24, 2019
merlimat
reviewed
Apr 24, 2019
conf/broker.conf
Outdated
| @@ -107,6 +107,9 @@ subscriptionRedeliveryTrackerEnabled=true | |||
| # How frequently to proactively check and purge expired subscription | |||
| subscriptionExpiryCheckIntervalInMinutes=5 | |||
|
|
|||
| # Enable Key_Shared subscription (default is disabled) | |||
| subscriptionKeySharedEnable=false | |||
There was a problem hiding this comment.
I was just meaning to have it enabled by default (with an option to disable)
There was a problem hiding this comment.
Enabled it by default and add a unit test to ensure disable is work well.
merlimat
approved these changes
Apr 24, 2019
jiazhai
approved these changes
Apr 25, 2019
sijie
reviewed
Apr 25, 2019
| @@ -150,6 +150,8 @@ In *Key_Shared* mode, multiple consumers can attach to the same subscription. Me | |||
|
|
|||
|  | |||
|
|
|||
| **Key_Shared subscription is a beta feature. You can disable it at broker.config.** | |||
There was a problem hiding this comment.
@codelipenghui shouldn't this be "You can enable it"?
There was a problem hiding this comment.
@sijie Key_shared subscription is enabled by default. so i think we need to tell users can disable it at broker.config
There was a problem hiding this comment.
There was a comments above to enable it by default.
sijie
approved these changes
Apr 25, 2019
15 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Add a broker level flag to enable or disable Key_Shared subscription, disabled by default.
Modifications
Add a flag named
subscriptionRedeliveryTrackerEnabledAdd documentation to describe Key_Shared subscription is a beta feature.
Verifying this change
This change is already covered by existing tests
Does this pull request potentially affect one of the following parts:
If
yeswas chosen, please highlight the changesDocumentation