Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add messaging integration tests for different subscriptions. #4352

Merged
merged 6 commits into from
May 24, 2019

Conversation

codelipenghui
Copy link
Contributor

Motivation

Add integration tests for message send and receive.

Cover different subscriptions:

  • Exclusive
  • Failover
  • Shared
  • Key_Shared

Does this pull request potentially affect one of the following parts:

If yes was chosen, please highlight the changes

  • Dependencies (does it add or upgrade a dependency): (no)
  • The public API: (no)
  • The schema: (no)
  • The default values of configurations: (no)
  • The wire protocol: (no)
  • The rest endpoints: (no)
  • The admin cli options: (no)
  • Anything that affects deployment: (no)

Documentation

  • Does this pull request introduce a new feature? (no)

@codelipenghui codelipenghui changed the title Add messaging integration tests. Add messaging integration tests for different subscriptions. May 23, 2019
Copy link
Member

@jiazhai jiazhai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @codelipenghui for this testing work

@codelipenghui
Copy link
Contributor Author

run Java8 Tests

@merlimat
Copy link
Contributor

@codelipenghui It's failing on KeySharedSubscriptionTest.testConsumerCrashSendAndReceiveWithHashRangeStickyKeyConsumerSelector which seems to be flaky #4353

@lovelle
Copy link
Contributor

lovelle commented May 24, 2019

KeySharedSubscriptionTest.testConsumerCrashSendAndReceiveWithHashRangeStickyKeyConsumerSelector fails on master branch for me.

@codelipenghui
Copy link
Contributor Author

Seems this is related to changes here https://github.com/apache/pulsar/pull/4329/files#diff-12d605952d013b598fd881f86c7cdefcL193.
I did some testing and found that this problem occurs when I close two consumers too quickly and if not included #4329 , UT can passed every time. I am trying to find out what the problem is.

Copy link
Contributor

@merlimat merlimat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@merlimat
Copy link
Contributor

Thanks for fixing this. It was indeed a regression in my change.

@codelipenghui
Copy link
Contributor Author

run Integration Tests

@codelipenghui
Copy link
Contributor Author

run Java8 Tests

@merlimat merlimat merged commit b161328 into apache:master May 24, 2019
@codelipenghui
Copy link
Contributor Author

relate to #4077

@codelipenghui codelipenghui deleted the messaging_integration_test branch May 19, 2021 05:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants