-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add messaging integration tests for different subscriptions. #4352
Add messaging integration tests for different subscriptions. #4352
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @codelipenghui for this testing work
run Java8 Tests |
@codelipenghui It's failing on KeySharedSubscriptionTest.testConsumerCrashSendAndReceiveWithHashRangeStickyKeyConsumerSelector which seems to be flaky #4353 |
|
Seems this is related to changes here https://github.com/apache/pulsar/pull/4329/files#diff-12d605952d013b598fd881f86c7cdefcL193. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Thanks for fixing this. It was indeed a regression in my change. |
run Integration Tests |
run Java8 Tests |
relate to #4077 |
Motivation
Add integration tests for message send and receive.
Cover different subscriptions:
Does this pull request potentially affect one of the following parts:
If
yes
was chosen, please highlight the changesDocumentation