-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix bug of Key_Shared Ordering #4372
Conversation
run Integration Tests |
run integration tests |
} | ||
|
||
protected void sendMessagesToConsumers(ReadType readType, List<Entry> entries) { | ||
int start = 0; | ||
int entriesToDispatch = entries.size(); | ||
long totalMessagesSent = 0; | ||
long totalBytesSent = 0; | ||
AtomicInteger messagesToConsumer = new AtomicInteger(entries.size()); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why do we need change this file? method sendMessagesToConsumers
got override in PersistentStickyKeyDispatcherMultipleConsumers
right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change not to solve the problem of Key_Shared subscription, i initial think this will reduce the reading frequency of ledger in shared subscription. This will wait for the message to be written to the consumers and then read again.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would suggest remove this change. since we have not meet this related issue in Shared mode, reading frequency of ledger is more controlled by other setting.
This is mainly for message ordering, and ordering is not need for shared mode.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agree, i'm already remove this change, PTAL.
run java8 tests |
2 similar comments
run java8 tests |
run java8 tests |
run integration tests |
run Integration Tests |
1 similar comment
run Integration Tests |
Motivation
Fix bug of Key_Shared ordering and add check for order by key, key distribution, message redelivery in Key_Shared subscription mode.
Does this pull request potentially affect one of the following parts:
If
yes
was chosen, please highlight the changesDocumentation