Key_Shared subscription on non-persistent topic #4462
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
relate to #4077 |
12 tasks
|
/cc @wolfstudy please help review the changes |
jiazhai
approved these changes
Jun 4, 2019
|
run cpp tests |
|
run java8 tests |
codelipenghui
force-pushed
the
key_shared_non_persistent
branch
from
8a6fe0e to
4dc111a
Compare
codelipenghui
force-pushed
the
key_shared_non_persistent
branch
from
4dc111a to
60c2bf4
Compare
|
LGTM +1 run java8 tests |
wolfstudy
reviewed
Jun 5, 2019
| int consumer1ExpectMessages = 0; | ||
| int consumer2ExpectMessages = 0; | ||
| int consumer3ExpectMessages = 0; | ||
|
|
There was a problem hiding this comment.
In the test case, the code of newConsumer() and newProducer() is repeated multiple times, whether consider encapsulation as a function?
There was a problem hiding this comment.
Nice suggestion, i'm already and separate method newConsumer and newProducer to create consumer and producer, PTAL.
15 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Support Key_Shared subscription on non-persistent topic
If
yeswas chosen, please highlight the changesDocumentation