Allow client(producer/consumer) to check topic stats #482
Conversation
rdhabalia
added
the
type/feature
| protected void validateAdminAndClientPermission(DestinationName destination) { | ||
| try { | ||
| validateAdminAccessOnProperty(destination.getProperty()); | ||
| } catch (Exception ve) { |
There was a problem hiding this comment.
Minor thing: do you think it would be easy to not rely on exceptions on the normal cases? Exception can be expensive to throw (basically it needs to generate the whole stack trace).
If that requires lot of refactoring, let's go ahead with this change.
There was a problem hiding this comment.
do you think it would be easy to not rely on exceptions
We can but then we need to ignore code-modularity where we need to modify property-check-function which will validate permission on property and topic based on given booleans which will decide what to validate. If it will be ugly and if we don't touch this method then we need to add duplicate code to introduce such method. so, do you think it's worth to introduce duplicate-code or ignoring modularity and stats call may not be used that often in normal case.
There was a problem hiding this comment.
That's ok, let's not worry about it for now
Motivation
In many cases subscribers of the topic requires to check the stats and internal-stats of the topics to check backlog, unack-messages, markDeletePosition, etc. Right now, broker only allows stats check to property owner and subscribers may not have property ownership.
Modifications
Allow producer/consumer to check the topic stats.
Result
producer/consumer can check the topic stats now.