Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Doc] Add *How to Use Pulsar Connectors* Guide #5071

Merged
merged 4 commits into from
Sep 2, 2019
Merged

[Doc] Add *How to Use Pulsar Connectors* Guide #5071

merged 4 commits into from
Sep 2, 2019

Conversation

Anonymitaet
Copy link
Member

@tuteng could you please help review? Many thanks

@Anonymitaet Anonymitaet changed the title [Doc]Add *How to Use Pulsar Connectors* Guide [Doc] Add *How to Use Pulsar Connectors* Guide Aug 29, 2019
@sijie sijie added doc Your PR contains doc changes, no matter whether the changes are in markdown or code files. component/website labels Aug 29, 2019
@sijie sijie added this to the 2.5.0 milestone Aug 29, 2019

* HTTP: http://www.repo.com/fileName.jar

* File: file:/dir/fileName.jar
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

File protocol format: file:///dir/fileName.jar

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is from JAVA admin API website

image

Is that incorrect?

**Response example**

```java
serviceUrl : "http://my-broker.example.com:8080/"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This response seems incorrect.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is from JAVA admin API website

image

What is the correct response?

**Response example**

```java
serviceUrl : "http://my-broker.example.com:8080/"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This response seems incorrect.

<!--Java Admin API-->

```java
SourceConfig getSource(String tenant,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

getSink?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops, thanks for reminding, I've corrected.

@sijie sijie merged commit 0917f8e into apache:master Sep 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc Your PR contains doc changes, no matter whether the changes are in markdown or code files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants