Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Doc] Update Canal source connector guide #5173

Merged
merged 5 commits into from
Sep 17, 2019
Merged

[Doc] Update Canal source connector guide #5173

merged 5 commits into from
Sep 17, 2019

Conversation

Anonymitaet
Copy link
Member

@Anonymitaet Anonymitaet commented Sep 11, 2019 •
edited
Loading

  1. I've updated this guide based on CanalSourceConfig.java and canal-mysql-source-config.yaml.

  2. Fix [Doc] Update Pulsar Connector Guide #5015

Anonymitaet
Anonymitaet commented Sep 11, 2019
View reviewed changes
Copy link
Member Author

@Anonymitaet Anonymitaet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tuteng could you please help review and answer the questions?

Anonymitaet
Anonymitaet commented Sep 11, 2019
View reviewed changes
site2/docs/io-cdc-canal.md Show resolved Hide resolved
site2/docs/io-cdc-canal.md Show resolved Hide resolved
@Anonymitaet Anonymitaet mentioned this pull request Sep 11, 2019
Closed
@Anonymitaet
Copy link
Member Author

@tuteng I've incorporated all your comments, could you PTAL?

@Jennifer88huang-zz Jennifer88huang-zz added component/connect doc Your PR contains doc changes, no matter whether the changes are in markdown or code files. labels Sep 12, 2019
@Jennifer88huang-zz Jennifer88huang-zz added this to the 2.5.0 milestone Sep 12, 2019
@Anonymitaet
Copy link
Member Author

@tuteng I've incorporated all your comments, could you PTAL?

@Anonymitaet
Copy link
Member Author

run cpp tests
run java8 tests

1 similar comment
@Anonymitaet
Copy link
Member Author

run cpp tests
run java8 tests

@Anonymitaet
Copy link
Member Author

run java8 tests

@Anonymitaet
Copy link
Member Author

run java8 tests

@sijie sijie merged commit 627e6f8 into apache:master Sep 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tuteng tuteng tuteng approved these changes

@sijie sijie sijie approved these changes

Assignees

@Anonymitaet Anonymitaet

Labels
area/connector doc Your PR contains doc changes, no matter whether the changes are in markdown or code files.
Projects
None yet
Milestone
2.5.0
Development

Successfully merging this pull request may close these issues.

[Doc] Update Pulsar Connector Guide
5 participants
@Anonymitaet @sijie @tuteng @tisonkun @Jennifer88huang-zz