Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Doc] Update *Debezium Connector Guide* #5197

Merged
merged 6 commits into from
Sep 18, 2019
Merged

[Doc] Update *Debezium Connector Guide* #5197

merged 6 commits into from
Sep 18, 2019

Conversation

Anonymitaet
Copy link
Member

No description provided.

@Anonymitaet
Copy link
Member Author

@tuteng could you please help review? Thank you

@Anonymitaet Anonymitaet changed the title Update *Debezium Connector Guide* [Doc] Update *Debezium Connector Guide* Sep 16, 2019
pulsar.service.url: "pulsar://127.0.0.1:6650"

## OFFSET_STORAGE_TOPIC_CONFIG
offset.storage.topic: "offset-topic"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There seems to be a loss of indentation here.

database.password: "postgres"
database.dbname: "postgres"
database.server.name: "dbserver1"
schema.whitelist: "inventory"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There seems to be a loss of indentation here.

@Anonymitaet
Copy link
Member Author

@tuteng I've incorporated all your comments, could you PTAL?

@tuteng
Copy link
Member

tuteng commented Sep 18, 2019

LGTM

@tuteng
Copy link
Member

tuteng commented Sep 18, 2019

run integration tests

@sijie sijie added component/connect doc Your PR contains doc changes, no matter whether the changes are in markdown or code files. labels Sep 18, 2019
@sijie sijie added this to the 2.5.0 milestone Sep 18, 2019
@sijie sijie merged commit 0bc9dab into apache:master Sep 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/connector doc Your PR contains doc changes, no matter whether the changes are in markdown or code files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants