Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Doc] Add *Kafka source connector guide* #5203

Merged
merged 3 commits into from
Sep 21, 2019
Merged

[Doc] Add *Kafka source connector guide* #5203

merged 3 commits into from
Sep 21, 2019

Conversation

Anonymitaet
Copy link
Member

Fix #5015

@Anonymitaet Anonymitaet mentioned this pull request Sep 17, 2019
Closed
Anonymitaet
Anonymitaet commented Sep 17, 2019
View reviewed changes
Copy link
Member Author

@Anonymitaet Anonymitaet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tuteng could you please help review? Thank you

@murong00
Copy link
Contributor

@Anonymitaet @tuteng Should we just aggregate the source and sink guide to one file, as you can share the same usage of a standalone kafka cluster.

@Anonymitaet
Copy link
Member Author

Anonymitaet commented Sep 18, 2019 •
edited
Loading

@murong00 I've added separate guides for both Kafka source connector (this PR) and Kafka sink connector (#5210) to improve clarity, does it make sense?

And they are shown independently in the list of the built-in connector as well, so I've set different URL (.md file) for each.
image

@sijie sijie added component/connect doc Your PR contains doc changes, no matter whether the changes are in markdown or code files. labels Sep 18, 2019
@sijie sijie added this to the 2.5.0 milestone Sep 18, 2019
@tuteng
Copy link
Member

tuteng commented Sep 19, 2019

run integration tests

2 similar comments
@Anonymitaet
Copy link
Member Author

run integration tests

@Anonymitaet
Copy link
Member Author

run integration tests

@aahmed-se aahmed-se merged commit 3af5951 into apache:master Sep 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@murong00 murong00 murong00 left review comments

@aahmed-se aahmed-se aahmed-se approved these changes

@tuteng tuteng tuteng approved these changes

Assignees

@Anonymitaet Anonymitaet

Labels
area/connector doc Your PR contains doc changes, no matter whether the changes are in markdown or code files.
Projects
None yet
Milestone
2.5.0
Development

Successfully merging this pull request may close these issues.

[Doc] Update Pulsar Connector Guide
6 participants
@Anonymitaet @murong00 @tuteng @aahmed-se @sijie @tisonkun