[Doc] Add *processing guarantee for connector* #5224
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@tuteng could you please help review? Thank you |
tuteng
reviewed
Sep 20, 2019
site2/docs/io-overview.md
Outdated
|
|
||
| * handle errors when writing messages to Pulsar topics. | ||
|
|
||
| * determine the subscription type used by Pulsar when reading messages from Pulsar topics. |
There was a problem hiding this comment.
I don't think this part of the content is necessary, and there is no necessary relationship between Processing guarantees and subscription type.
There was a problem hiding this comment.
@tuteng thank you. I've incorporated your comment, could you PTAL?
|
run java8 tests |
merlimat
added
the
doc
tuteng
approved these changes
Sep 23, 2019
Jennifer88huang-zz
approved these changes
Sep 27, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #5015