Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Doc] Add *Netty source connector guide* #5253

Merged
merged 1 commit into from
Sep 24, 2019
Merged

[Doc] Add *Netty source connector guide* #5253

merged 1 commit into from
Sep 24, 2019

Conversation

Anonymitaet
Copy link
Member

Fix #5015

@Anonymitaet Anonymitaet mentioned this pull request Sep 23, 2019
Closed
Anonymitaet
Anonymitaet commented Sep 23, 2019
View reviewed changes
site2/docs/io-netty-source.md
$ docker exec -it pulsar-netty-standalone /bin/bash

$ curl -X POST --data 'hello, world!' http://127.0.0.1:10999/
```
Copy link
Member Author

@Anonymitaet Anonymitaet Sep 23, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tuteng are step 6 and step 7 correct?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, it is correct.

Anonymitaet
Anonymitaet commented Sep 23, 2019
View reviewed changes
Copy link
Member Author

@Anonymitaet Anonymitaet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tuteng could you please help review? Thank you

tuteng
tuteng approved these changes Sep 24, 2019
View reviewed changes
site2/docs/io-netty-source.md
$ docker exec -it pulsar-netty-standalone /bin/bash

$ curl -X POST --data 'hello, world!' http://127.0.0.1:10999/
```
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, it is correct.

@tuteng
Copy link
Member

tuteng commented Sep 24, 2019

run integration tests

@merlimat merlimat added the doc Your PR contains doc changes, no matter whether the changes are in markdown or code files. label Sep 24, 2019
@merlimat merlimat merged commit b2bf4a7 into apache:master Sep 24, 2019
@Anonymitaet Anonymitaet deleted the netty-source branch September 25, 2019 01:42
@Anonymitaet
Copy link
Member Author

@merlimat Thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tuteng tuteng tuteng approved these changes

@merlimat merlimat merlimat approved these changes

Assignees
No one assigned
Labels
doc Your PR contains doc changes, no matter whether the changes are in markdown or code files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Doc] Update Pulsar Connector Guide
3 participants
@Anonymitaet @tuteng @merlimat