Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Doc] Add *Aerospike sink connector guide* #5256

Merged
merged 3 commits into from
Sep 27, 2019
Merged

[Doc] Add *Aerospike sink connector guide* #5256

merged 3 commits into from
Sep 27, 2019

Conversation

Anonymitaet
Copy link
Member

Fix #5015

@Anonymitaet Anonymitaet mentioned this pull request Sep 23, 2019
Closed
Anonymitaet
Anonymitaet commented Sep 23, 2019
View reviewed changes
Copy link
Member Author

@Anonymitaet Anonymitaet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tuteng could you please help review? Thank you

tuteng
tuteng reviewed Sep 24, 2019
View reviewed changes
site2/docs/io-aerospike-sink.md Outdated Show resolved Hide resolved
site2/docs/io-aerospike-sink.md Show resolved Hide resolved
@Anonymitaet
Copy link
Member Author

run cpp tests

@Anonymitaet
Copy link
Member Author

@tuteng I've incorporated all your comments, could you PTAL?

@Anonymitaet
Copy link
Member Author

run cpp tests

1 similar comment
@Anonymitaet
Copy link
Member Author

run cpp tests

@merlimat merlimat added the doc Your PR contains doc changes, no matter whether the changes are in markdown or code files. label Sep 24, 2019
@tuteng
Copy link
Member

tuteng commented Sep 25, 2019

run java8 tests

6 similar comments
@Anonymitaet
Copy link
Member Author

run java8 tests

@Anonymitaet
Copy link
Member Author

run java8 tests

@Anonymitaet
Copy link
Member Author

run java8 tests

@Anonymitaet
Copy link
Member Author

run java8 tests

@Anonymitaet
Copy link
Member Author

run java8 tests

@Anonymitaet
Copy link
Member Author

run java8 tests

@Jennifer88huang-zz Jennifer88huang-zz merged commit 7f1d5ec into apache:master Sep 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jennifer88huang-zz Jennifer88huang-zz Jennifer88huang-zz approved these changes

@tuteng tuteng tuteng approved these changes

Assignees
No one assigned
Labels
doc Your PR contains doc changes, no matter whether the changes are in markdown or code files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Doc] Update Pulsar Connector Guide
4 participants
@Anonymitaet @tuteng @Jennifer88huang-zz @merlimat