avoid unsafe split when validate hostname which might be ipv6 address #5713
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change-Id: I21c6f161270afc1d279c52d98ddf956abcf64741
Change-Id: I7cc94cca8d6c3f3981c74795013e2ce24a029b76
|
The failed tests seem unrelated. |
|
run cpp tests |
1 similar comment
|
run cpp tests |
|
run cpp tests |
sijie
requested changes
Nov 26, 2019
| @@ -122,6 +122,18 @@ public void testUserInfo() { | |||
| "/path/to/namespace"); | |||
| } | |||
|
|
|||
| @Test | |||
| public void testIpv6Uri() { | |||
There was a problem hiding this comment.
Can you add a test case of using ipv6 address without port?
Change-Id: I8b127438886c9c414746a0dae90fc3a5ea50f5c7
sijie
approved these changes
Nov 27, 2019
sijie
added
the
type/enhancement
|
run integration tests |
1 similar comment
|
run integration tests |
|
run integration tests |
sijie
approved these changes
Dec 20, 2019
huangdx0726
pushed a commit
to huangdx0726/pulsar
that referenced
this pull request
Aug 24, 2020
…apache#5713) ### Motivation Pulsar doesn't support deploy on IPv6 network environment. This PR just makes an effort to make it. The error happens if the client connect to brokers by IPv6 address, like fec0:0:0:ffff::1. - Wrong format: fec0:0:0:ffff::1:6650 - Correct format: [fec0:0:0:ffff::1]:6650 Cause the split regex is ':', brackets are needed and the ip:port can't split by ':' directly. ### Modifications validateHostName in ServiceURI
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Pulsar doesn't support deploy on IPv6 network environment.
This PR just makes an effort to make it.
The error happens if the client connect to brokers by IPv6 address, like fec0:0:0:ffff::1.
Cause the split regex is ':', brackets are needed and the ip:port can't split by ':' directly.
Modifications
validateHostName in ServiceURI