Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expose bookkeeper expose explicit lac configuration in broker.conf #5822

Merged
merged 1 commit into from
Feb 10, 2020
Merged

Expose bookkeeper expose explicit lac configuration in broker.conf #5822

merged 1 commit into from
Feb 10, 2020

Conversation

codelipenghui
Copy link
Contributor

@codelipenghui codelipenghui commented Dec 9, 2019 •
edited by jiazhai
Loading

Motivation

Expose bookkeeper expose explicit lac configuration in broker.conf
It's related to #3828 #4976, some Pulsar SQL users need to enable the explicitLacInterval, so that they can get the last message in Pulsar SQL.

Verifying this change

Added unit tests.

Does this pull request potentially affect one of the following parts:

If yes was chosen, please highlight the changes

  • Dependencies (does it add or upgrade a dependency): (no)
  • The public API: (no)
  • The schema: (no)
  • The default values of configurations: (yes)
  • The wire protocol: (no)
  • The rest endpoints: (no)
  • The admin cli options: (no)
  • Anything that affects deployment: (no)

Documentation

  • Does this pull request introduce a new feature? (no)

@codelipenghui codelipenghui self-assigned this Dec 9, 2019
@codelipenghui
Copy link
Contributor Author

related to #3828 #4976

@codelipenghui codelipenghui mentioned this pull request Dec 9, 2019
Closed
@codelipenghui
Copy link
Contributor Author

run java8 tests
run integration tests

2 similar comments
@codelipenghui
Copy link
Contributor Author

run java8 tests
run integration tests

@codelipenghui
Copy link
Contributor Author

run java8 tests
run integration tests

@fangpengcheng95
Copy link
Contributor

@codelipenghui what should we do to deal with “ Integration Tests Failure”？just retry?

@codelipenghui
Copy link
Contributor Author

@fangpengcheng95 Some tests are unstable, some times we need to rerun it

@codelipenghui
Copy link
Contributor Author

run integration tests

@rdhabalia
Copy link
Contributor

can you please describe need of this configuration and how it will help or impact the behavior?

@codelipenghui
Copy link
Contributor Author

@rdhabalia It's related to #3828 #4976, some Pulsar SQL users need to enable the explicitLacInterval, so that they can get the last message in Pulsar SQL

@codelipenghui
Copy link
Contributor Author

run integration tests

@jiazhai
Copy link
Member

jiazhai commented Dec 17, 2019

run integration tests

@jiazhai
Copy link
Member

jiazhai commented Dec 17, 2019

@rdhabalia It's related to #3828 #4976, some Pulsar SQL users need to enable the explicitLacInterval, so that they can get the last message in Pulsar SQL

Added these above into description.

@codelipenghui
Copy link
Contributor Author

run integration tests

1 similar comment
@jiazhai
Copy link
Member

jiazhai commented Dec 18, 2019

run integration tests

@sijie
Copy link
Member

sijie commented Dec 20, 2019

run integration tests

@sijie sijie added this to the 2.5.0 milestone Dec 20, 2019
@codelipenghui
Copy link
Contributor Author

run integration tests

4 similar comments
@codelipenghui
Copy link
Contributor Author

run integration tests

@codelipenghui
Copy link
Contributor Author

run integration tests

@codelipenghui
Copy link
Contributor Author

run integration tests

@codelipenghui
Copy link
Contributor Author

run integration tests

@codelipenghui
Copy link
Contributor Author

rerun integration tests

@sijie
Copy link
Member

sijie commented Jan 8, 2020

run java8 tests
run integration tests

2 similar comments
@codelipenghui
Copy link
Contributor Author

run java8 tests
run integration tests

@codelipenghui
Copy link
Contributor Author

run java8 tests
run integration tests

@codelipenghui
Copy link
Contributor Author

run java8 tests

@codelipenghui
Copy link
Contributor Author

run java8 tests
run integration tests

@codelipenghui
Copy link
Contributor Author

run integration tests

@codelipenghui
Copy link
Contributor Author

run java8 tests
run integration tests

2 similar comments
@sijie
Copy link
Member

sijie commented Jan 11, 2020

run java8 tests
run integration tests

@codelipenghui
Copy link
Contributor Author

run java8 tests
run integration tests

@codelipenghui
Copy link
Contributor Author

codelipenghui commented Jan 17, 2020 •
edited
Loading

run integration tests

org.apache.pulsar.tests.integration.cli.CLITest.pulsar-test-suite
org.apache.pulsar.tests.integration.schema.SchemaTest.pulsar-test-suite
org.apache.pulsar.tests.integration.functions.PulsarFunctionsProcessTest.pulsar-test-suite
org.apache.pulsar.tests.integration.presto.TestBasicPresto.pulsar-test-suite
org.apache.pulsar.tests.integration.functions.PulsarFunctionsThreadTest.pulsar-test-suite
org.apache.pulsar.tests.integration.offload.TestS3Offload.tiered-storage-test-suite
org.apache.pulsar.tests.integration.offload.TestFileSystemOffload.tiered-storage-test-suite
org.apache.pulsar.tests.integration.functions.PulsarStateTest.pulsar-standalone-suite
org.apache.pulsar.tests.integration.messaging.PersistentTopicMessagingTest.pulsar-test-suite

@codelipenghui
Copy link
Contributor Author

run integration tests

@sijie sijie mentioned this pull request Jan 24, 2020
Closed
@codelipenghui codelipenghui merged commit 4fd17d4 into apache:master Feb 10, 2020
@codelipenghui codelipenghui mentioned this pull request Feb 12, 2020
Merged
@codelipenghui codelipenghui deleted the expose_explicit_lac branch February 17, 2020 09:17
tuteng pushed a commit to AmateurEvents/pulsar that referenced this pull request Feb 23, 2020
@codelipenghui @tuteng
Expose bookkeeper expose explicit lac in broker.conf (apache#5822)
c8eb719 
### Motivation

Expose bookkeeper expose explicit lac configuration in broker.conf
It's related to apache#3828 apache#4976, some Pulsar SQL users need to enable the explicitLacInterval, so that they can get the last message in Pulsar SQL.
tuteng pushed a commit to AmateurEvents/pulsar that referenced this pull request Mar 21, 2020
@codelipenghui @tuteng
Expose bookkeeper expose explicit lac in broker.conf (apache#5822)
f98d4c1 
### Motivation

Expose bookkeeper expose explicit lac configuration in broker.conf
It's related to apache#3828 apache#4976, some Pulsar SQL users need to enable the explicitLacInterval, so that they can get the last message in Pulsar SQL.

(cherry picked from commit 4fd17d4)
tuteng pushed a commit that referenced this pull request Apr 13, 2020
@codelipenghui @tuteng
Expose bookkeeper expose explicit lac in broker.conf (#5822)
c421d26 
### Motivation

Expose bookkeeper expose explicit lac configuration in broker.conf
It's related to #3828 #4976, some Pulsar SQL users need to enable the explicitLacInterval, so that they can get the last message in Pulsar SQL.

(cherry picked from commit 4fd17d4)
This was referenced May 6, 2020
Closed
Merged
jiazhai pushed a commit to jiazhai/pulsar that referenced this pull request May 18, 2020
@codelipenghui @jiazhai
Expose bookkeeper expose explicit lac in broker.conf (apache#5822)
652ada3 
### Motivation

Expose bookkeeper expose explicit lac configuration in broker.conf
It's related to apache#3828 apache#4976, some Pulsar SQL users need to enable the explicitLacInterval, so that they can get the last message in Pulsar SQL.
(cherry picked from commit 4fd17d4)
@sijie sijie mentioned this pull request May 20, 2020
Closed
huangdx0726 pushed a commit to huangdx0726/pulsar that referenced this pull request Aug 24, 2020
@codelipenghui @huangdx0726
Expose bookkeeper expose explicit lac in broker.conf (apache#5822)
6eca5dd 
### Motivation

Expose bookkeeper expose explicit lac configuration in broker.conf
It's related to apache#3828 apache#4976, some Pulsar SQL users need to enable the explicitLacInterval, so that they can get the last message in Pulsar SQL.
@AntiBit82 AntiBit82 mentioned this pull request Feb 18, 2022
Closed
@sijie sijie mentioned this pull request Feb 18, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jiazhai jiazhai jiazhai approved these changes

@sijie sijie sijie approved these changes

@rdhabalia rdhabalia Awaiting requested review from rdhabalia

Assignees

@codelipenghui codelipenghui

Labels
area/config release/2.5.1
Projects
None yet
Milestone
2.6.0
Development

Successfully merging this pull request may close these issues.
7 participants
@codelipenghui @fangpengcheng95 @rdhabalia @jiazhai @sijie @wolfstudy @tuteng