Add pending-blocked-message-permits to dispatcher while redelivery of pending messages #63
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CLA is valid! |
2 similar comments
|
CLA is valid! |
|
CLA is valid! |
rdhabalia
force-pushed
the
unack_block
branch
from
2ed98fd
to
79073b8
Compare
rdhabalia
changed the title
rdhabalia
force-pushed
the
unack_block
branch
from
79073b8
to
0e40e95
Compare
sboobna
reviewed
Oct 14, 2016
| // dispatch pending permits to flow more messages: it will add more permits to dispatcher and consumer | ||
| subscription.consumerFlow(consumer, additionalNumberOfPermits); | ||
| // add newly flow permits to actual consumer.messagePermits | ||
| consumer.messagePermits.getAndAdd(additionalNumberOfPermits); |
There was a problem hiding this comment.
We should update the messagePermits before sending the flow just to be consistent
| subscription.consumerFlow(this, additionalNumberOfMessages); | ||
| }else { |
There was a problem hiding this comment.
addressed both the comments.. thanks.
rdhabalia
force-pushed
the
unack_block
branch
from
0e40e95
to
1468f6d
Compare
|
Looks good, but wanted to check it with fresh eyes tomorrow |
rdhabalia
force-pushed
the
unack_block
branch
2 times, most recently
from
1468f6d
to
b07112b
Compare
|
@merlimat : addressed renaming changes. |
…f pending messages
rdhabalia
force-pushed
the
unack_block
branch
from
b07112b
to
d9ca1f7
Compare
merlimat
approved these changes
Oct 17, 2016
hangc0276
pushed a commit
to hangc0276/pulsar
that referenced
this pull request
May 26, 2021
Fixes apache#63 *Movitation* Migrate the jenkins to the Github Action.
nicoloboschi
referenced
this pull request
in nicoloboschi/pulsar
Apr 12, 2022
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
When Consumer is blocked due to not acking max-unack_threshold messages: Consumer keeps adding flow-permits to
messagePermitsand doesn't sends it toDispatcheruntil consumer gets unblocked again.In Mean time, if
redeliveryrequests comes thenDispatcherdoesn't send additional number of messages for permits which came after consumer was blocked.(1) messagePermit before consumer blocked
(2) messagePermit after consumer blocked.
So, when consumer receives redelivery request: it can redeliver number of blocked-permit messages in message-replay.
Modifications
Introduce two message permit counts to support redelivery of messages when consumer is blocked and client-consumer actually has more permits to receive more messages.
Result
It delivers messages on
redelivery-messagerequest by also considering permits which comes after consumer got blocked due to reaching unack-message-threshold.