Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[broker] Expose BookKeeper GetBookieInfo settings #6800

Merged
merged 1 commit into from
Apr 29, 2020
Merged

[broker] Expose BookKeeper GetBookieInfo settings #6800

merged 1 commit into from
Apr 29, 2020

Conversation

addisonj
Copy link
Contributor

Motivation

Bookkeeper has settings to allow for periodic calls to refresh the
bookie info. In dynamic environments (like when running on k8s) fetching
the bookie info more often can be helpful to ensure the brokers stay up
to date on the list of bookies even in the event of zookeeper watch
issues.

Modifications

This commit adds the settings to customize these options in the bookie client

Verifying this change

This change is a trivial rework / code cleanup without any test coverage.

Does this pull request potentially affect one of the following parts:

If yes was chosen, please highlight the changes

  • Dependencies (does it add or upgrade a dependency): no
  • The public API: no
  • The schema: no
  • The default values of configurations: no, but new config added
  • The wire protocol: no
  • The rest endpoints: no
  • The admin cli options: no
  • Anything that affects deployment: no

Documentation

  • Does this pull request introduce a new feature? yes
  • If yes, how is the feature documented? new config, reference added

[broker] Expose BookKeeper GetBookieInfo settings
8dc5b9f 
Bookkeeper has settings to allow for periodic calls to refresh the
bookie info. In dynamic environments (like when running on k8s) fetching
the bookie info more often can be helpful to ensure the brokers stay up
to date on the list of bookies even in the event of zookeeper watch
issues.
@addisonj
Copy link
Contributor Author

/pulsarbot run-failure-checks

2 similar comments
@addisonj
Copy link
Contributor Author

/pulsarbot run-failure-checks

@addisonj
Copy link
Contributor Author

/pulsarbot run-failure-checks

@sijie sijie added this to the 2.6.0 milestone Apr 29, 2020
@sijie sijie added area/config type/enhancement The enhancements for the existing features or docs. e.g. reduce memory usage of the delayed messages labels Apr 29, 2020
@sijie sijie merged commit c8d0c68 into apache:master Apr 29, 2020
cdbartholomew pushed a commit to kafkaesque-io/pulsar that referenced this pull request Apr 29, 2020
@addisonj @cdbartholomew
[broker] Expose BookKeeper GetBookieInfo settings (apache#6800)
9ac9ed0 
Bookkeeper has settings to allow for periodic calls to refresh the
bookie info. In dynamic environments (like when running on k8s) fetching
the bookie info more often can be helpful to ensure the brokers stay up
to date on the list of bookies even in the event of zookeeper watch
issues.

Co-authored-by: Addison Higham <ahigham@instructure.com>
gaoran10 pushed a commit to gaoran10/pulsar that referenced this pull request May 5, 2020
@addisonj @gaoran10
[broker] Expose BookKeeper GetBookieInfo settings (apache#6800)
87a7f61 
Bookkeeper has settings to allow for periodic calls to refresh the
bookie info. In dynamic environments (like when running on k8s) fetching
the bookie info more often can be helpful to ensure the brokers stay up
to date on the list of bookies even in the event of zookeeper watch
issues.

Co-authored-by: Addison Higham <ahigham@instructure.com>
gaoran10 pushed a commit to gaoran10/pulsar that referenced this pull request May 5, 2020
@addisonj @gaoran10
[broker] Expose BookKeeper GetBookieInfo settings (apache#6800)
ff68af1 
Bookkeeper has settings to allow for periodic calls to refresh the
bookie info. In dynamic environments (like when running on k8s) fetching
the bookie info more often can be helpful to ensure the brokers stay up
to date on the list of bookies even in the event of zookeeper watch
issues.

Co-authored-by: Addison Higham <ahigham@instructure.com>
addisonj added a commit to instructure/pulsar that referenced this pull request May 7, 2020
@addisonj
[broker] Expose BookKeeper GetBookieInfo settings (apache#6800)
b2b728d 
Bookkeeper has settings to allow for periodic calls to refresh the
bookie info. In dynamic environments (like when running on k8s) fetching
the bookie info more often can be helpful to ensure the brokers stay up
to date on the list of bookies even in the event of zookeeper watch
issues.

Co-authored-by: Addison Higham <ahigham@instructure.com>
@sijie sijie mentioned this pull request May 20, 2020
Closed
cdbartholomew pushed a commit to kafkaesque-io/pulsar that referenced this pull request May 23, 2020
@addisonj @cdbartholomew
[broker] Expose BookKeeper GetBookieInfo settings (apache#6800)
6c28245 
Bookkeeper has settings to allow for periodic calls to refresh the
bookie info. In dynamic environments (like when running on k8s) fetching
the bookie info more often can be helpful to ensure the brokers stay up
to date on the list of bookies even in the event of zookeeper watch
issues.

Co-authored-by: Addison Higham <ahigham@instructure.com>
Huanli-Meng pushed a commit to Huanli-Meng/pulsar that referenced this pull request May 27, 2020
@addisonj @Huanli-Meng
[broker] Expose BookKeeper GetBookieInfo settings (apache#6800)
498a6e4 
Bookkeeper has settings to allow for periodic calls to refresh the
bookie info. In dynamic environments (like when running on k8s) fetching
the bookie info more often can be helpful to ensure the brokers stay up
to date on the list of bookies even in the event of zookeeper watch
issues.

Co-authored-by: Addison Higham <ahigham@instructure.com>
addisonj added a commit to instructure/pulsar that referenced this pull request Jun 12, 2020
@addisonj
[broker] Expose BookKeeper GetBookieInfo settings (apache#6800)
381383c 
Bookkeeper has settings to allow for periodic calls to refresh the
bookie info. In dynamic environments (like when running on k8s) fetching
the bookie info more often can be helpful to ensure the brokers stay up
to date on the list of bookies even in the event of zookeeper watch
issues.

Co-authored-by: Addison Higham <ahigham@instructure.com>
huangdx0726 pushed a commit to huangdx0726/pulsar that referenced this pull request Aug 24, 2020
@addisonj @huangdx0726
[broker] Expose BookKeeper GetBookieInfo settings (apache#6800)
f749c83 
Bookkeeper has settings to allow for periodic calls to refresh the
bookie info. In dynamic environments (like when running on k8s) fetching
the bookie info more often can be helpful to ensure the brokers stay up
to date on the list of bookies even in the event of zookeeper watch
issues.

Co-authored-by: Addison Higham <ahigham@instructure.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sijie sijie sijie approved these changes

Assignees

@addisonj addisonj

Labels
area/config type/enhancement The enhancements for the existing features or docs. e.g. reduce memory usage of the delayed messages
Projects
None yet
Milestone
2.6.0
Development

Successfully merging this pull request may close these issues.
2 participants
@addisonj @sijie