Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Issue: 7029] Fix presto SQL does not start prometheus service by default #7030

Merged
merged 1 commit into from
May 25, 2020
Merged

[Issue: 7029] Fix presto SQL does not start prometheus service by default #7030

merged 1 commit into from
May 25, 2020

Conversation

wolfstudy
Copy link
Member

Signed-off-by: xiaolong.ran rxl@apache.org

Fixes #7029

Motivation

As described in # 7029, when starting sql-worker, users expect to be able to correctly access the service port of Prometheus: 9092

Modifications

  • When start sql-worker, go to initialize the Connector's cache.

@wolfstudy
Fix presto SQL does not start prometheus service by default
e9eff26 
Signed-off-by: xiaolong.ran <rxl@apache.org>
@wolfstudy wolfstudy requested a review from jerrypeng May 25, 2020 05:20
@wolfstudy wolfstudy self-assigned this May 25, 2020
@wolfstudy wolfstudy added this to the 2.6.0 milestone May 25, 2020
@wolfstudy
Copy link
Member Author

@sijie @jiazhai @codelipenghui PTAL thanks.

@wolfstudy wolfstudy mentioned this pull request May 25, 2020
Closed
@wolfstudy wolfstudy merged commit 7880425 into apache:master May 25, 2020
315157973 pushed a commit to 315157973/pulsar that referenced this pull request May 29, 2020
@wolfstudy @315157973
Fix presto SQL does not start prometheus service by default (apache#7030
d06b47d 
)

Signed-off-by: xiaolong.ran <rxl@apache.org>
Huanli-Meng pushed a commit to Huanli-Meng/pulsar that referenced this pull request Jun 1, 2020
@wolfstudy @Huanli-Meng
Fix presto SQL does not start prometheus service by default (apache#7030
0cc014e 
)

Signed-off-by: xiaolong.ran <rxl@apache.org>
Huanli-Meng pushed a commit to Huanli-Meng/pulsar that referenced this pull request Jun 1, 2020
@wolfstudy @Huanli-Meng
Fix presto SQL does not start prometheus service by default (apache#7030
666b5ed 
)

Signed-off-by: xiaolong.ran <rxl@apache.org>
@sijie sijie mentioned this pull request Jun 10, 2020
Closed
Huanli-Meng pushed a commit to Huanli-Meng/pulsar that referenced this pull request Jun 12, 2020
@wolfstudy @Huanli-Meng
Fix presto SQL does not start prometheus service by default (apache#7030
d82b824 
)

Signed-off-by: xiaolong.ran <rxl@apache.org>
huangdx0726 pushed a commit to huangdx0726/pulsar that referenced this pull request Aug 24, 2020
@wolfstudy @huangdx0726
Fix presto SQL does not start prometheus service by default (apache#7030
cabd19d 
)

Signed-off-by: xiaolong.ran <rxl@apache.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@codelipenghui codelipenghui codelipenghui approved these changes

@jerrypeng jerrypeng Awaiting requested review from jerrypeng

@jiazhai jiazhai Awaiting requested review from jiazhai

@sijie sijie Awaiting requested review from sijie

Assignees

@wolfstudy wolfstudy

Labels
None yet
Projects
None yet
Milestone
2.6.0
Development

Successfully merging this pull request may close these issues.

By default, presto SQL does not start the prometheus service
2 participants
@wolfstudy @codelipenghui