-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[C++] Fix Result can't be serialized to string inside the library #7034
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
/pulsarbot run-failure-checks |
2 similar comments
/pulsarbot run-failure-checks |
/pulsarbot run-failure-checks |
sijie
approved these changes
May 26, 2020
/pulsarbot run-failure-checks |
1 similar comment
/pulsarbot run-failure-checks |
merlimat
approved these changes
May 27, 2020
315157973
pushed a commit
to 315157973/pulsar
that referenced
this pull request
May 29, 2020
Huanli-Meng
pushed a commit
to Huanli-Meng/pulsar
that referenced
this pull request
Jun 1, 2020
Huanli-Meng
pushed a commit
to Huanli-Meng/pulsar
that referenced
this pull request
Jun 1, 2020
Huanli-Meng
pushed a commit
to Huanli-Meng/pulsar
that referenced
this pull request
Jun 12, 2020
huangdx0726
pushed a commit
to huangdx0726/pulsar
that referenced
this pull request
Aug 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
When a
Result
was passed tostd::ostream::operator<<
inside the library, the overloadedoperator<<
wouldn't be called. InsteadResult
was treated as a integer. For example, if you subscribed to a topic of a namespace that didn't exist, the error log would be:Giving following code:
ss << result
inside namespacepulsar
doesn't call::operator(ss, result)
. Instead, it callspulsar::operator(ss, result)
, which hasn't been overloaded. Because nearly all methods are in namespacepulsar
, theLOG_XXX(... << result)
won't call::operator<<(std::ostream&, Result)
.Modifications
operator<<
forResult
from global namespace to namespacepulsar
.