[pulsar-client-cpp] Support Seek on Partitioned Topic by Time #7198
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
merlimat
requested changes
Jun 8, 2020
| } | ||
| stateLock.unlock(); | ||
| for (ConsumerList::const_iterator i = consumers_.begin(); i != consumers_.end(); i++) { | ||
| (*i)->seekAsync(msgId, callback); |
There was a problem hiding this comment.
The message id is only relative to 1 partition. Seeking with same message id on multiple partition will position the subscription in the wrong position.
There was a problem hiding this comment.
I understood that.
This PR decides to support only seeking on partitioned topic by time.
| callback(ResultOperationNotSupported); | ||
| Lock stateLock(mutex_); | ||
| if (state_ != Ready) { | ||
| callback(ResultAlreadyClosed); |
There was a problem hiding this comment.
The mutex should be released before triggering the callback, since that might be blocking
k2la
changed the title
|
/pulsarbot run-failure-checks |
1 similar comment
|
/pulsarbot run-failure-checks |
merlimat
approved these changes
Jun 8, 2020
cdbartholomew
pushed a commit
to kafkaesque-io/pulsar
that referenced
this pull request
Jul 24, 2020
huangdx0726
pushed a commit
to huangdx0726/pulsar
that referenced
this pull request
Aug 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modifications
Support seek on partitioned topic.
Verifying this change