Use local broker address as serviceURL when running WebSocket component embedded in broker #82
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nt embedded in broker Fixes apache#77
|
CLA is valid! |
2 similar comments
|
CLA is valid! |
|
CLA is valid! |
sijie
pushed a commit
to sijie/pulsar
that referenced
this pull request
Mar 4, 2018
massakam
pushed a commit
to massakam/pulsar
that referenced
this pull request
Aug 6, 2020
```
var client = new Pulsar.Client({
log: function(level /* typescript enum */, file, line, message) {
// log with console.log or other logging implementation
}
})
```
If no log function is passed, it will use default logging.
hrsakai
pushed a commit
to hrsakai/pulsar
that referenced
this pull request
Dec 10, 2020
…che#82) * Added a message id tracker for acking messages that are batched. * Update ack tracker functions.
hangc0276
pushed a commit
to hangc0276/pulsar
that referenced
this pull request
May 26, 2021
) Fix apache#74 This change is to refine the project structure to make nar file the default deploy way. Also kept the old building style of tar.gz, and we could remove it in the future. (apache#83 ) For the tests, mainly use PulsarService, and leverage nar loading for KoP protocol handler init. * renamed, pass unit tests * pass test using pular broker * move and fix group Coordinator and GroupMetadataManager test * move and fix DistributedClusterTest and KafkaApisTest * move and fix KafkaRequestHandlerTest and KafkaRequestTypeTest * move and fix KafkaSSLChannelTest and KafkaTopicConsumerManagerTest * move and fix MultiLedgerTest and PulsarAuthEnabledTest * move and fix SaslPlainTest * remove dup tests * add KafkaBrokerStarter back, to also keep the tar binary build * change Readme * fix checkstyle * action: build before check * split tests * bypass integration tests * add producer retry logic in DistributedClusterTest * catch client exception * change following comments
hangc0276
pushed a commit
to hangc0276/pulsar
that referenced
this pull request
May 26, 2021
in PR apache#82, structure is refined, but publish.sh leaked the change. * fix publish.sh for dir refine * delete integrations/__init__.py * ignore dir dev in script
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
As described in #77, when WebSocket component is running embedded inside the broker and a VIP system is used as service discovery, there will be an authentication issue when the broker connects to itself, because the IP will be different.
Modifications
When WebSocket compute is running embedded in broker, always connect to local broker, without going through service discovery.
Result
Fixes #77