Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make protoc compiler to use 'pulsar::proto' as C++ namespace #87

Merged
merged 1 commit into from
Oct 26, 2016
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions pulsar-common/src/main/proto/PulsarApi.proto
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
* See the License for the specific language governing permissions and
* limitations under the License.
*/
package com.yahoo.pulsar.common.api.proto;
package pulsar.proto;
option java_package = "com.yahoo.pulsar.common.api.proto";
option optimize_for = LITE_RUNTIME;

Expand Down Expand Up @@ -50,7 +50,7 @@ message MessageMetadata {
repeated string replicate_to = 7;
optional CompressionType compression = 8 [default = NONE];
optional uint32 uncompressed_size = 9 [default = 0];
// Removed below checksum field from Metadata as
// Removed below checksum field from Metadata as
// it should be part of send-command which keeps checksum of header + payload
//optional sfixed64 checksum = 10;
// differentiate single and batch message metadata
Expand Down Expand Up @@ -264,7 +264,7 @@ message BaseCommand {

PING = 18;
PONG = 19;

REDELIVER_UNACKNOWLEDGED_MESSAGES = 20;
}

Expand Down Expand Up @@ -294,4 +294,3 @@ message BaseCommand {
optional CommandPong pong = 19;
optional CommandRedeliverUnacknowledgedMessages redeliverUnacknowledgedMessages = 20;
}