Fix: Reset message-header index while verifying checksum-strip at Reconnection #90
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CLA is valid! |
2 similar comments
|
CLA is valid! |
|
CLA is valid! |
sijie
added a commit
to sijie/pulsar
that referenced
this pull request
Mar 4, 2018
* Move worker module out of runtime module * Fix license header issues
hrsakai
pushed a commit
to hrsakai/pulsar
that referenced
this pull request
Dec 10, 2020
* Removed unacked messages tracker * Fixed tests
hangc0276
pushed a commit
to hangc0276/pulsar
that referenced
this pull request
May 26, 2021
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
At reconnection: before resending messages, producer verifies broker-version and removes checksum and modifies prepared message if requires. If message is not modified then message-header index is not reset correctly which can corrupt the message.
This problem would only happen in a mixed environment with 1.15 and 1.14 clients.
Fix is also available in 1.15.1
Modifications
Reset message-header index while stripping checksum.
Result
It will not corrupt message while resending message on reconnection.