Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix flaky unit test #9262

Merged
merged 3 commits into from
Jan 22, 2021
Merged

fix flaky unit test #9262

merged 3 commits into from
Jan 22, 2021

Conversation

315157973
Copy link
Contributor

Motivation

Topic level policy cache will only trigger initialization when OwnedNamespaceBundle. The following unit tests do not create producers or consumers, and just wait through sleep.
The cache will not initialize no matter how long it wait. If the cache is called without initializing, an error of 500 will be reported
So I created a producer or consumer for these tests, and avoided sleep

eolivelli
eolivelli approved these changes Jan 21, 2021
View reviewed changes
Copy link
Contributor

@eolivelli eolivelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
I was going down this way in this commit
624441f

@sijie sijie added this to the 2.8.0 milestone Jan 21, 2021
@315157973
Copy link
Contributor Author

/pulsarbot run-failure-checks

1 similar comment
@315157973
Copy link
Contributor Author

/pulsarbot run-failure-checks

@eolivelli
Copy link
Contributor

@315157973 your error is this one

~/work/pulsar/pulsar/pulsar-client-all
     [java] The following classes needed for analysis were missing:
     [java]   jline.console.completer.Completer
Error:  Failed to execute goal on project pulsar-io-hbase: Could not resolve dependencies for project org.apache.pulsar:pulsar-io-hbase:jar:2.8.0-SNAPSHOT: Failed to collect dependencies at org.apache.hbase:hbase-server:jar:2.3.0 -> org.glassfish.web:javax.servlet.jsp:jar:2.3.2 -> org.glassfish:javax.el:jar:3.0.1-b06-SNAPSHOT: Failed to read artifact descriptor for org.glassfish:javax.el:jar:3.0.1-b06-SNAPSHOT: Could not transfer artifact org.glassfish:javax.el:pom:3.0.1-b06-SNAPSHOT from/to spring-plugins-release (https://repo.spring.io/plugins-release/): Authentication failed for https://repo.spring.io/plugins-release/org/glassfish/javax.el/3.0.1-b06-SNAPSHOT/javax.el-3.0.1-b06-SNAPSHOT.pom 401 Unauthorized -> [Help 1]

I guess we should commit #9278 and your error will go away
cc @codelipenghui @zymap

@merlimat merlimat merged commit 65b3a62 into apache:master Jan 22, 2021
@315157973 315157973 deleted the unit-test4 branch February 23, 2021 13:01
eolivelli pushed a commit to datastax/pulsar that referenced this pull request May 24, 2021
@315157973 @eolivelli
fix flaky unit test (apache#9262)
11c7353 
* fix unit test

* set timeout to 10 sec

(cherry picked from commit 65b3a62)
@eolivelli eolivelli added cherry-picked/branch-2.7 Archived: 2.7 is end of life release/2.7.3 labels May 25, 2021
eolivelli pushed a commit that referenced this pull request May 25, 2021
@315157973 @eolivelli
fix flaky unit test (#9262)
eba5d11 
* fix unit test

* set timeout to 10 sec
@eolivelli
Copy link
Contributor

I have cherry picked this patch to branch-2.7

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eolivelli eolivelli eolivelli approved these changes

@jiazhai jiazhai jiazhai approved these changes

@sijie sijie sijie approved these changes

Assignees

@315157973 315157973

Labels
cherry-picked/branch-2.7 Archived: 2.7 is end of life release/2.7.3 type/flaky-tests
Projects
None yet
Milestone
2.8.0
Development

Successfully merging this pull request may close these issues.
5 participants
@315157973 @eolivelli @sijie @jiazhai @merlimat