Merged
Conversation
sijie
approved these changes
Feb 4, 2021
Member
sijie
left a comment
sijie
left a comment
There was a problem hiding this comment.
@JipeiWang Thank you for putting this guideline! That's useful! I only have one small comment. Otherwise, it looks good.
Co-authored-by: Sijie Guo <sg@streamnative.io>
Huanli-Meng
reviewed
Feb 4, 2021
Contributor
Huanli-Meng
left a comment
Huanli-Meng
left a comment
There was a problem hiding this comment.
leave my comments, PTAL.
In addition, please pay attention to the indent of contents under each step.
site2/website/contributing.md
Outdated
| `logo_white: true` | ||
|
|
||
| 3. Commit the changes in your account’s repo, publish the branch and create pull request. | ||
| 4. Wait for review. If the PR works, your pull request will be approved and merged by reviewers. |
Contributor
There was a problem hiding this comment.
Suggested change
| 4. Wait for review. If the PR works, your pull request will be approved and merged by reviewers. | |
| 4. Update comments, if any. If no more comment, ask reviewers to approve the PR and merge the PR to the master. |
site2/website/contributing.md
Outdated
| { | ||
| name: 'StreamNative', | ||
| url: 'https://streamnative.io/', | ||
| logo: 'https://streamnative.io/static/images/streamnative-logo-white-bakground.png', |
Contributor
There was a problem hiding this comment.
Suggested change
| logo: 'https://streamnative.io/static/images/streamnative-logo-white-bakground.png', | |
| logo: 'https://streamnative.io/static/images/streamnative-logo-white-bakground.png', | |
| logo_white: true |
site2/website/contributing.md
Outdated
| logo: 'https://streamnative.io/static/images/streamnative-logo-white-bakground.png', | ||
| } | ||
| ` | ||
| If your company logo is in white color, add another line after the logo link in JSON file: |
Contributor
There was a problem hiding this comment.
Note
Thelogo_whiteparameter is set totrueonly when your company logo uses a white background.
site2/website/contributing.md
Outdated
| The Apache Pulsar Community welcomes all users to update their company logos on Pulsar website. If your team or organization has adopted Pulsar in production, please update your company logos on [Pulsar website](https://pulsar.apache.org/en/powered-by/). | ||
|
|
||
| It only takes 4 steps to update your company logo: | ||
| 1. Open [link](https://github.com/apache/pulsar/blob/master/site2/website/data/users.js) in your browser, click “edit” to fork Pulsar repo, create a new branch and edit this file. |
Contributor
There was a problem hiding this comment.
Suggested change
| 1. Open [link](https://github.com/apache/pulsar/blob/master/site2/website/data/users.js) in your browser, click “edit” to fork Pulsar repo, create a new branch and edit this file. | |
| 1. Open this [link](https://github.com/apache/pulsar/blob/master/site2/website/data/users.js) in your browser, and then click the **Edit** icon (it looks like a pencil) to edit this file. |
Co-authored-by: Jennifer Huang <47805623+Jennifer88huang@users.noreply.github.com>
Co-authored-by: Huanli Meng <48120384+Huanli-Meng@users.noreply.github.com>
Co-authored-by: Huanli Meng <48120384+Huanli-Meng@users.noreply.github.com>
Huanli-Meng
reviewed
Feb 5, 2021
site2/website/contributing.md
Outdated
| ></br>The `logo_white` parameter is set to true only when your company logo is in white color. Otherwise, you only need to add `name`, `url` and `logo`. | ||
|
|
||
| 3. Commit the changes in your account’s repo, publish the branch and create pull request. | ||
| 4. Update comments, if any. If no more comment, your pull request will be approved and merged by reviewers. |
Contributor
There was a problem hiding this comment.
Suggested change
| 4. Update comments, if any. If no more comment, your pull request will be approved and merged by reviewers. | |
| 4. Update comments, if any. If no more comment, your pull request will be approved and merged by reviewers. |
sijie
approved these changes
Feb 5, 2021
Member
|
@JipeiWang Thanks for your contribution, that's great. It will be helpful for operating. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Invite Pulsar users to update their company logos on Pulsar website.
Modifications
Add workflow of updating logos.