-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[C++] Remove Boost::System runtime dependency #9498
Conversation
/pulsarbot run-failure-checks |
* [C++] Remove Boost::System runtime dependency * Only remove it if Boost>=1.69 * Fixed condition * Check for missing variables on older cmake versions
Hi Matteo, I just have a question. Is there any reference to prove that from 1.69 the Boost::System dependency is not required? I went to https://www.boost.org/doc/libs/1_69_0/doc/html/boost_asio/using.html#boost_asio.using.dependencies and found
I've tested Boost 1.74 and 1.75 in my local environment, it worked well without Boost::System dependency. But I'm still curious about whether 1.69 is the first version that doesn't require Boost::System dependency. |
@BewareMyPower Here you go: https://www.boost.org/doc/libs/1_76_0/libs/system/doc/html/system.html#changes_in_boost_1_69
|
@merlimat Thanks for your guide! |
* [C++] Remove Boost::System runtime dependency * Only remove it if Boost>=1.69 * Fixed condition * Check for missing variables on older cmake versions
Motivation
Linking with Boost::System was only required by Asio if we were not using C++11 flags. Since this was updated a while ago, we don't need to link with System anymore.