PROTON-2202 [go] Add ability to set capability on the terminus struct #235
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d98762625
commented
Mar 27, 2020
| @@ -32,13 +32,6 @@ func ExampleParseURL() { | |||
| "amqps://host", | |||
| "/path", | |||
| "", | |||
| ":1234", | |||
There was a problem hiding this comment.
Removing this invalid case and the commented out ones, as per the comment on this PR
jiridanek
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We found that we needed to be able to set capabilities on the terminus struct, otherwise we couldn't share queues.
This PR adds a getter and setter for capabilities on the terminus struct.