Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PROTON-1870 reproducers in Python for overly generic TLS errors #261

Draft
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

jiridanek
Copy link
Contributor

I do realize that the tests are extremely similar to the existing TLS tests in Proton Python. It felt much easier to write it gradually from scratch than to fit it into existing test helpers right from the beginning.

This issue may require writing similar tests for all the other bindings.

@jiridanek
Copy link
Contributor Author

There is something in the test that starts TLS server in Python that is incompatible with older Python 2.x on Ubuntu, and something in all of the TLS tests that expect Proton TLS to work, that fails on Windows. This issue is on a back burner at this point, so I will not look into fixing this for now.

@jiridanek jiridanek added the wip label Jul 10, 2020
@jiridanek jiridanek marked this pull request as draft February 20, 2021 14:01
@codecov-commenter
Copy link

Codecov Report

Merging #261 (23f1a13) into main (3f13a38) will increase coverage by 18.64%.
The diff coverage is n/a.

❗ Current head 23f1a13 differs from pull request most recent head 6e64e9b. Consider uploading reports for the commit 6e64e9b to get more accurate results

@@             Coverage Diff             @@
##             main     #261       +/-   ##
===========================================
+ Coverage   69.69%   88.34%   +18.64%     
===========================================
  Files         370       47      -323     
  Lines       69864     2394    -67470     
===========================================
- Hits        48695     2115    -46580     
+ Misses      21169      279    -20890     
Impacted Files Coverage Δ
python/tests/proton_tests/transport.py
build/c/src/core/object/string.c
c/tests/proactor_test.cpp
c/tests/pn_test_test.cpp
c/src/core/types.c
cpp/src/transport.cpp
cpp/include/proton/scalar_base.hpp
cpp/include/proton/codec/vector.hpp
c/src/core/engine.c
cpp/src/connection_driver.cpp
... and 313 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants