Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PROTON-2402: Clarify proton docs for on_sendable, prefetch for Messag… #324

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

NS-SlaFleur
Copy link
Contributor

…ingHandler, send for Sender and thread-safety for Container.

https://issues.apache.org/jira/browse/PROTON-2402

…ingHandler, send for Sender and thread-safety for Container.
@codecov-commenter
Copy link

codecov-commenter commented Jun 25, 2021

Codecov Report

Merging #324 (5c834cf) into main (a3d1ef4) will increase coverage by 19.68%.
The diff coverage is n/a.

❗ Current head 5c834cf differs from pull request most recent head 2a10d7a. Consider uploading reports for the commit 2a10d7a to get more accurate results
Impacted file tree graph

@@             Coverage Diff             @@
##             main     #324       +/-   ##
===========================================
+ Coverage   68.66%   88.34%   +19.68%     
===========================================
  Files         351       47      -304     
  Lines       70321     2394    -67927     
===========================================
- Hits        48285     2115    -46170     
+ Misses      22036      279    -21757     
Impacted Files Coverage Δ
cpp/include/proton/source.hpp
cpp/examples/message_properties.cpp
build/c/src/core/util.c
cpp/src/error.cpp
cpp/include/proton/internal/object.hpp
python/proton/_selectable.py
cpp/src/map.cpp
cpp/include/proton/binary.hpp
c/tests/connection_driver_test.cpp
c/src/handlers/handshaker.c
... and 291 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a3d1ef4...2a10d7a. Read the comment docs.

@NS-SlaFleur
Copy link
Contributor Author

@NS-MNellen will take over this PR if there are any questions.

@astitcher astitcher requested a review from ssorj April 11, 2023 18:46
@astitcher
Copy link
Member

@ssorj Could you look at these doc changes and see if you think this is an improvement.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants