PROTON-2471 Run raw connection examples during proton-c examples test #345
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jiridanek
force-pushed
the
jd_PROTON-2433_interface_library_dirs
branch
from
506936a
to
cb82d5b
Compare
jiridanek
commented
Nov 29, 2021
Comment on lines
+125
to
+128
| expected_brief = b'**raw connection connected\n' + message + b'**raw connection disconnected\n' | ||
| expected_polite = b'**raw connection connected\n' + message + b'** Goodbye ****raw connection disconnected\n' | ||
|
|
||
| expected = expected_polite if b'Goodbye' in stdout else expected_brief |
There was a problem hiding this comment.
I'm at a loss how to get deterministic output from the example. Sometimes it manages to receive and print that Goodbye, but oftentimes not.
|
The CI fails on Windows and macOS are legit. Raw feature is not implemented in other than epoll proactor. Test has to be skipped. |
|
There is no good way to propagate the info about proactor availability to the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.