Extend frame logging to optionally decode transfer payloads as AMQP #347
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
astitcher
force-pushed
the
logger/extended-frame
branch
from
7d83de6
to
393c3f3
Compare
|
In response to some feedback I've made the full frame logging the default (and only) behaviour when frame tracing is turned on (PN_LOG=frame). The extra control wasn't very useful, at least for this proof of concept. Now that null values are not printed in frame traces the traces become significantly less cluttered and more useful than before. |
|
My intention is to split out the fixed string work from this branch as it isn't really the focus of this WIP, but an independently useful change which gos to bounding the size of the logging buffers that be received by a logger sink. |
This should probably only try to decode the transfer performative. But currently the frame dumper has no way to feed back anything about the AMQP value it just dumped.
astitcher
force-pushed
the
logger/extended-frame
branch
from
393c3f3
to
20220c7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can turn on this extra frame logging by setting the 'frame+' log level. This can usually be done by setting the PN_LOG environment variable to 'frame+'
This PR also contains changes to the recent AMQP value dump code so that it uses a fixed size string output buffer instead of using the pn_string_t type which will grow indefinitely.
I'd be very interested in people using this extra frame trace to see whether they think it's useful.