Skip to content

Conversation

@rameeshm
Copy link
Contributor

What changes were proposed in this pull request?

This patch is to include test users in the Ranger Base image to make those users available in ranger and associated containers

Signed-off-by: Ramesh Mani <rmani@apache.org>
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request refactors user and group creation in the Ranger Docker base image by extracting the inline shell commands into a dedicated script, and adds test users (testuser1, testuser2, testuser3) in a testgroup to support testing scenarios.

  • Replaces inline RUN commands with a reusable bash script for creating users and groups
  • Adds test users (testuser1, testuser2, testuser3) and testgroup to the base image
  • Consolidates user creation logic into helper functions for better maintainability

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 5 comments.

File Description
docker/create_users_and_groups.sh New script that creates all required users and groups including the new test users with reusable helper functions
docker/Dockerfile Removes inline user/group creation commands and integrates the new script for user setup

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@rameeshm rameeshm requested a review from kumaab January 1, 2026 04:09
@rameeshm rameeshm merged commit de9303f into main Jan 2, 2026
7 checks passed
@rameeshm rameeshm deleted the RANGER-5365-patch branch January 2, 2026 05:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants