-
Notifications
You must be signed in to change notification settings - Fork 1
RANGER-5365:Add test users into Ranger Docker Base Image #6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Ramesh Mani <rmani@apache.org>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This pull request refactors user and group creation in the Ranger Docker base image by extracting the inline shell commands into a dedicated script, and adds test users (testuser1, testuser2, testuser3) in a testgroup to support testing scenarios.
- Replaces inline RUN commands with a reusable bash script for creating users and groups
- Adds test users (testuser1, testuser2, testuser3) and testgroup to the base image
- Consolidates user creation logic into helper functions for better maintainability
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 5 comments.
| File | Description |
|---|---|
| docker/create_users_and_groups.sh | New script that creates all required users and groups including the new test users with reusable helper functions |
| docker/Dockerfile | Removes inline user/group creation commands and integrates the new script for user setup |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
What changes were proposed in this pull request?
This patch is to include test users in the Ranger Base image to make those users available in ranger and associated containers