RANGER-2713: Remove audit fields from XXPolicyRef objects #211
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewluotechnologies
force-pushed
the
RANGER-2713
branch
from
6e77963 to
fa92126
Compare
andrewluotechnologies
force-pushed
the
RANGER-2713
branch
from
44c104c to
5a391d8
Compare
…yZoneRef, XXRoleRef objects XXPolicyRef, XXSecurityZoneRef, and XXRoleRef objects have fields such as guid, create time, update time, added by user ID, updated by user ID, but these fields are entirely useless since they are all copied from the parent object. In addition, while improving performance for creation of policies with large numbers of users, we discovered that a lot of time was being spent in JPA converting these Date objects especially. After removing these fields we saw a significant performance improvement (a secondary benefit is less database space usage).
andrewluotechnologies
force-pushed
the
RANGER-2713
branch
from
5a391d8 to
75db38c
Compare
Contributor
|
@andrewluotechnologies - thank you for the patch. It is merged in master and ranger-2.8 branches via #796. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
XXPolicyRef objects have fields such as create time, update time, added by user ID, updated by user ID, but there fields are entirely useless since they are all copied from the XXPolicy object. In addition, while improving performance for creation of policies with large numbers of users, we discovered that a lot of time was being spent in JPA converting these Date objects especially. After removing these fields we saw a significant performance improvement (a secondary benefit is less database space usage).