RANGER-5078: Set ranger.usersync.ldap.referral=follow as default config #530
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
Updates the default LDAP referral behavior in the UserSync component from “ignore” to “follow” across installation scripts and code.
- Changed
SYNC_LDAP_REFERRALdefault value in two install.properties scripts - Updated the Java config constant
DEFAULT_LGSYNC_REFERRALto"follow"
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| unixauthservice/scripts/install.properties | Set SYNC_LDAP_REFERRAL default to follow |
| ugsync/src/main/java/org/apache/ranger/unixusersync/config/UserGroupSyncConfig.java | Updated DEFAULT_LGSYNC_REFERRAL to "follow" |
| dev-support/ranger-docker/scripts/ranger-usersync-install.properties | Set SYNC_LDAP_REFERRAL default to follow |
Comments suppressed due to low confidence (1)
ugsync/src/main/java/org/apache/ranger/unixusersync/config/UserGroupSyncConfig.java:126
- Add or update a unit or integration test to verify that the default LDAP referral is now set to
follow, preventing future regressions.
private static final String DEFAULT_LGSYNC_REFERRAL = "follow";
| SYNC_PAGED_RESULTS_SIZE= | ||
| #LDAP context referral could be ignore or follow | ||
| SYNC_LDAP_REFERRAL =ignore | ||
| SYNC_LDAP_REFERRAL=follow |
There was a problem hiding this comment.
[nitpick] Add a # default value: follow comment above this line and adjust spacing to match other properties (e.g., SYNC_LDAP_REFERRAL = follow).
| SYNC_PAGED_RESULTS_SIZE= | ||
| #LDAP context referral could be ignore or follow | ||
| SYNC_LDAP_REFERRAL =ignore | ||
| SYNC_LDAP_REFERRAL=follow |
There was a problem hiding this comment.
[nitpick] Add a # default value: follow comment above this line and align the spacing around = with the surrounding property definitions.
spolavarpau1
approved these changes
Jun 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Changes the default value of
ranger.usersync.ldap.referralfromignoretofollowHow was this patch tested?
Verified that the config parameter is populated correctly in
ranger-ugsync-site.xmlin docker deployment ofranger-usersync.