Skip to content
This repository was archived by the owner on Aug 4, 2022. It is now read-only.

Conversation

@afchung
Copy link
Contributor

@afchung afchung commented May 9, 2016

…tion

This addressed the issue by

  • Adding the interface IDataMover, which abstracts the movement of data between different memory layers.
  • Adding the DataCache class, which abstracts the caching of data at different storage layers.
  • Changing the IInputPartitionn interface to work with the new ISerializer.

JIRA:
REEF-1357

…tion

This addressed the issue by
  * Adding the interface IDataMover, which abstracts the movement of data between different memory layers.
  * Adding the DataCache class, which abstracts the caching of data at different storage layers.
  * Changing the IInputPartitionn interface to work with the new ISerializer.

JIRA:
  [REEF-1357](https://issues.apache.org/jira/browse/REEF-1357)
[Unstable("0.14", "Contract may change.")]
void Cache();
[Unstable("0.15", "Contract may change.")]
CacheLevel Cache(CacheLevel level);
Copy link
Contributor

@dkm2110 dkm2110 May 10, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we plan to modify or remove this function altogether in near future. Or is it related to the fact that we plan to give range of options from user min,max than simply one cache level.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is just related to the fact that the API is not stabilized yet, and we don't want to lock ourselves into any commitments with regards to backward compatibility.

@dkm2110
Copy link
Contributor

dkm2110 commented May 10, 2016

@afchung left comments.

@afchung
Copy link
Contributor Author

afchung commented May 11, 2016

@dkm2110 I've been trying to add test for DataMover and DataCache, but it seems we can't reliably do so without faking a wrapper interface on top of DirectoryInfo and FileInfo, at the least. Given that adding the wrapper interfaces will take up a lot of lines and obfuscate the CR, I'll split this into two tasks - creating the interfaces and then this PR (REEF-1357). I'll close this PR first. Thanks for the review!

@afchung afchung closed this May 11, 2016
@dkm2110
Copy link
Contributor

dkm2110 commented May 11, 2016

@afchung Makes sense. Thanks!!

@afchung
Copy link
Contributor Author

afchung commented May 11, 2016

@dkm2110 Please take a look at #997 when you have time. Thanks!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants