Skip to content

Conversation

ShannonDing
Copy link
Member

What is the purpose of the change

feat(consumer): remove event if consumer service shutdown

@ShannonDing ShannonDing added the enhancement New feature or request label Jan 16, 2020
@ShannonDing ShannonDing added this to the 1.2.5 milestone Jan 16, 2020
@codecov-io
Copy link

Codecov Report

Merging #233 into master will decrease coverage by 0.03%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #233      +/-   ##
==========================================
- Coverage   52.87%   52.83%   -0.04%     
==========================================
  Files         174      174              
  Lines       10986    10994       +8     
==========================================
  Hits         5809     5809              
- Misses       5177     5185       +8
Impacted Files Coverage Δ
src/consumer/DefaultMQPushConsumer.cpp 6.4% <0%> (-0.05%) ⬇️
src/consumer/ConsumeMessageConcurrentlyService.cpp 0% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f968f57...56e85bc. Read the comment docs.

@ShannonDing ShannonDing merged commit fd29759 into apache:master Jan 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants