Skip to content

fix(transaction): failed to select transaction producer to call local state checker #246

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 19, 2020
Merged

fix(transaction): failed to select transaction producer to call local state checker #246

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a65ae8a
fix(transaction): failed to select transaction producer to call local…
ShannonDing Feb 18, 2020
f783281
fix(transaction): fix the coredump when the transaction producer shut…
ShannonDing Feb 18, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/MQClientFactory.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@
#include "PullRequest.h"
#include "Rebalance.h"
#include "TopicPublishInfo.h"
#include "TransactionMQProducer.h"
#include "TransactionMQProducerImpl.h"

#define MAX_BUFF_SIZE 8192
#define SAFE_BUFF_SIZE 7936 // 8192 - 256 = 7936
Expand Down Expand Up @@ -698,7 +698,7 @@ void MQClientFactory::checkTransactionState(const std::string& addr,
if (!group.empty()) {
MQProducer* producer = selectProducer(group);
if (producer != nullptr) {
TransactionMQProducer* transProducer = dynamic_cast<TransactionMQProducer*>(producer);
TransactionMQProducerImpl* transProducer = dynamic_cast<TransactionMQProducerImpl*>(producer);
if (transProducer != nullptr) {
transProducer->checkTransactionState(addr, messageExt, checkRequestHeader.m_tranStateTableOffset,
checkRequestHeader.m_commitLogOffset, checkRequestHeader.m_msgId,
Expand Down
4 changes: 0 additions & 4 deletions src/extern/CProducer.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -261,10 +261,6 @@ int DestroyProducer(CProducer* pProducer) {
delete defaultMQProducer->innerTransactionProducer;
defaultMQProducer->innerTransactionProducer = NULL;
}
if (defaultMQProducer->listenerInner != NULL) {
delete defaultMQProducer->listenerInner;
defaultMQProducer->listenerInner = NULL;
}
} else {
if (defaultMQProducer->innerProducer != NULL) {
delete defaultMQProducer->innerProducer;
Expand Down