Realization C asynSend #65

githublaohu · 2019-01-10T12:06:51Z

No description provided.

messense · 2019-01-10T14:20:04Z

src/extern/CProducer.cpp

+	}
+	DefaultMQProducer *defaultMQProducer = (DefaultMQProducer *) producer;
+	MQMessage *message = (MQMessage *) msg;
+	CSendCallback* cSendCallback = new CSendCallback(cSendSuccessCallback , cSendExceptionCallback);


cSendCallback should be deleted after send

See MQClientAPIImpl::sendMessageAsync and AsyncCallbackWrap::operationComplete（90 line），and AsyncCallbackWrap::onException()[ 117 line]

jonnxu · 2019-01-11T00:38:48Z

include/CMQException.h

+typedef struct _CMQException_{
+	int error;
+	int line;
+	char file[MAX_MESSAGE_ID_LENGTH];


why use the same macro MAX_MESSAGE_ID_LENGTH to different member here

Already processed

jonnxu · 2019-01-11T01:02:40Z

include/CProducer.h


 //typedef struct _CProducer_ _CProducer;
 typedef struct CProducer CProducer;
 typedef int(*QueueSelectorCallback)(int size, CMessage *msg, void *arg);


why need the parameter size, what's it function?

QueueSelectorCallback is not asyn send callback function

jonnxu · 2019-01-11T01:05:32Z

include/MQClientException.h


  virtual const char* GetType() const throw() { return m_type.c_str(); }

+  int GetLine() const throw(){ return m_line;}


there will no exception for GetLine and GetFile, so need delete throw() for them

Already processed

jonnxu · 2019-01-11T01:09:13Z

src/extern/CProducer.cpp

+		exception.error = e.GetError();
+		exception.line  = e.GetLine();
+		strncpy(exception.msg, e.what(), MAX_MESSAGE_ID_LENGTH - 1);
+		strncpy(exception.file, e.GetFile(), MAX_MESSAGE_ID_LENGTH - 1);


wrong alignment, format them

Already processed

jonnxu · 2019-01-11T01:27:41Z

src/extern/CProducer.cpp

-		  cout << "send Exception\n";
-	  }
-public:
+    virtual void onException(MQException& e) {


please format the alignment

Already processed

ShannonDing · 2019-01-10T13:57:56Z

src/extern/CProducer.cpp

+	}
+	virtual ~CSendCallback(){}
+	virtual void onSuccess(SendResult& sendResult) {
+		cout << "send onSuccess\n";


Please remove stdout.

@githublaohu Could you please check this?

thanks , Already processed

ShannonDing · 2019-01-10T14:00:32Z

include/MQClientException.h

+
+#include <string.h>
 #include "RocketMQClient.h"
+#include "CCommon.h"


Why include C type head file here? it is better to remove it.

Already processed

ShannonDing · 2019-01-10T14:07:57Z

src/extern/CProducer.cpp

+	try {
+		defaultMQProducer->send(*message ,cSendCallback);
+	} catch (exception &e) {
+		return PRODUCER_SEND_ONEWAY_FAILED;


The error code is not right.

@githublaohu it is better to define a new error code.

Already processed

ShannonDing · 2019-01-15T02:12:16Z

include/CMQException.h

+	int line;
+	char file[MAX_EXEPTION_CHAR_LENGTH];
+	char msg[MAX_EXEPTION_CHAR_LENGTH];
+	char type[MAX_EXEPTION_CHAR_LENGTH];


it is better to define the MACRO separately, and the length of msg maybe bigger than 256, IMO, maybe 512 is better.

Already processed

ShannonDing · 2019-01-15T02:28:17Z

example/CAsyncProducer.c

+    for (i = 0; i < 10; i++) {
+        printf("send one message : %d\n", i);
+        memset(DestMsg, 0, sizeof(DestMsg));
+        snprintf(DestMsg, 255, "New message body: index %d", i);


It is better to use sizeof(DestMsg) instead of 255.

DestMsg chang to body? variable need keep the same style, that is first word for variable with lowercase

Already processed

githublaohu added 5 commits January 6, 2019 21:46

asyn

de9ea92

pure virtual method called

e0779fa

complete

04a708d

add CMQException

6a9776b

BROADCASTING conflict

1541a5d

messense reviewed Jan 10, 2019

View reviewed changes

jonnxu reviewed Jan 11, 2019

View reviewed changes

exception delete cSendCallback

dd4ddc9

ShannonDing reviewed Jan 15, 2019

View reviewed changes

change

0cb2025

ShannonDing reviewed Jan 15, 2019

View reviewed changes

change

214d683

ShannonDing merged commit e628502 into apache:master Jan 16, 2019

ShannonDing added the new feature label Jan 21, 2019

ShannonDing added this to the 1.2.1 milestone Jan 21, 2019


		virtual const char* GetType() const throw() { return m_type.c_str(); }

		int GetLine() const throw(){ return m_line;}

Realization C asynSend #65

Realization C asynSend #65

Uh oh!

Conversation

githublaohu commented Jan 10, 2019

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!