Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Native] fix concurrent map read/write for findBrokerVersion #334

Closed
xujianhai666 opened this issue Dec 20, 2019 · 1 comment
Closed

[Native] fix concurrent map read/write for findBrokerVersion #334

xujianhai666 opened this issue Dec 20, 2019 · 1 comment
Milestone
2.0.0-RC1

Comments

@xujianhai666
Copy link
Member

BUG REPORT
Please add the branch name [Native]/[Master] at the header of the Isssue title.

  1. Please describe the issue you observed:

    • What did you do (The steps to reproduce)?
      we found concurrent map read and map write on findBrokerVersion method, and we found some detail are not consistent with java.

    • What did you expect to see?

    • What did you see instead?

  2. Please tell us about your environment:

    • What is your OS?

    • What is your client version?

    • What is your RocketMQ version?

  3. Other information (e.g. detailed explanation, logs, related issues, suggestions on how to fix, etc):

FEATURE REQUEST

  1. Please describe the feature you are requesting.

  2. Provide any additional detail on your proposed use case for this feature.

  3. Indicate the importance of this issue to you (blocker, must-have, should-have, nice-to-have). Are you currently using any workarounds to address this issue?

  4. If there are some sub-tasks using -[] for each subtask and create a corresponding issue to map to the sub task:
xujianhai666 added a commit to xujianhai666/rocketmq-client-go that referenced this issue Dec 20, 2019
@xujianhai666
feat(core): fix concurrent read/write for broker version
d449899 
- use lock and simple map to replace sync.map
- fix map usage, the map should be brokerName -> addr -> version instead of brokerName -> brokerName -> verison

Closes apache#334
wenfengwang pushed a commit that referenced this issue Dec 20, 2019
@xujianhai666 @wenfengwang
feat(core): fix concurrent read/write for broker version (#333)
3f00503 
- fix concurrent read/write for broker version 
Closes #334
@wenfengwang
Copy link
Member

close due to #333

@wenfengwang wenfengwang added this to the 2.0.0-RC1 milestone Dec 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.0.0-RC1
Development

No branches or pull requests
2 participants
@wenfengwang @xujianhai666