Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE #407] feat: reuse bytes.Buffer #408

Merged
merged 1 commit into from
Feb 24, 2020

Conversation

xujianhai666
Copy link
Member

  • use sync.pool of bytes.Buffer instead of new

Closes #407

Copy link
Member

@ShannonDing ShannonDing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

primitive/message.go:367:15: undefined: createMessageId

@ShannonDing ShannonDing added the discuss Something undering disscussing label Feb 18, 2020
- use sync.pool of bytes.Buffer instead of new

Closes apache#407
@xujianhai666 xujianhai666 force-pushed the feat-apache-buffer-reuse branch from 3200702 to 831ae72 Compare February 22, 2020 15:16
@codecov-io
Copy link

Codecov Report

Merging #408 into native will decrease coverage by 0.12%.
The diff coverage is 93.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           native     #408      +/-   ##
==========================================
- Coverage   25.19%   25.06%   -0.13%     
==========================================
  Files          47       48       +1     
  Lines        5474     5486      +12     
==========================================
- Hits         1379     1375       -4     
- Misses       3907     3924      +17     
+ Partials      188      187       -1
Impacted Files Coverage Δ
primitive/pool.go 58.82% <100%> (+46.32%) ⬆️
primitive/message.go 25.31% <83.33%> (+0.31%) ⬆️
consumer/consumer.go 16.25% <0%> (-1.72%) ⬇️
consumer/push_consumer.go 12.41% <0%> (-0.4%) ⬇️
internal/client.go 0.23% <0%> (-0.01%) ⬇️
primitive/errors.go 0% <0%> (ø)
internal/route.go 9.87% <0%> (+0.06%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f9e5f75...831ae72. Read the comment docs.

@ShannonDing ShannonDing merged commit 2e05fc0 into apache:native Feb 24, 2020
@ShannonDing ShannonDing added this to the 2.0.0 milestone Feb 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
discuss Something undering disscussing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants