Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(consumer): use sync offset fix instead if async #414

Merged

Conversation

xujianhai666
Copy link
Member

@xujianhai666 xujianhai666 commented Feb 16, 2020

Closes #413
close #413

@codecov-io
Copy link

Codecov Report

Merging #414 into native will increase coverage by <.01%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           native     #414      +/-   ##
==========================================
+ Coverage    24.9%   24.91%   +<.01%     
==========================================
  Files          48       48              
  Lines        5480     5478       -2     
==========================================
  Hits         1365     1365              
+ Misses       3928     3926       -2     
  Partials      187      187
Impacted Files Coverage Δ
consumer/push_consumer.go 12.41% <0%> (+0.03%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update adc707f...46ede68. Read the comment docs.

@ShannonDing ShannonDing added the enhancement New feature or request label Feb 18, 2020
@ShannonDing ShannonDing merged commit 089cc03 into apache:native Feb 19, 2020
@ShannonDing ShannonDing added this to the 2.0.0 milestone Feb 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants